Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable DevMojoIT.testResourcesFromClasspath() #10647

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Re-enable DevMojoIT.testResourcesFromClasspath() #10647

merged 1 commit into from
Jul 13, 2020

Conversation

famod
Copy link
Member

@famod famod commented Jul 10, 2020

@famod famod requested a review from geoand July 10, 2020 18:19
@geoand
Copy link
Contributor

geoand commented Jul 10, 2020

Let's see what CI says

@famod
Copy link
Member Author

famod commented Jul 13, 2020

@geoand CI is green. Good to merge? Or do we need a rebase?

@geoand
Copy link
Contributor

geoand commented Jul 13, 2020

Let's merge it, although I think the test might have to be disabled altogether (as I saw it fail in Linux tests once)

@geoand geoand merged commit 937ab78 into quarkusio:master Jul 13, 2020
@famod famod deleted the win-DevMojoIT-testResourcesFromClasspath branch July 13, 2020 16:30
@famod
Copy link
Member Author

famod commented Jul 13, 2020

I think the test might have to be disabled altogether (as I saw it fail in Linux tests once)

👍 -> #10675 (comment)

I'll try to add more diagnostic output.

@geoand
Copy link
Contributor

geoand commented Jul 13, 2020

Cool!

@famod
Copy link
Member Author

famod commented Jul 13, 2020

Reproducible sooner or later via:

while mvn clean test -Dtest=DevMojoIT#testResourcesFromClasspath -f integration-tests/maven/; do :; done

@famod
Copy link
Member Author

famod commented Jul 13, 2020

On Windows:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:2.5:clean (default-clean) on project multimodule-cp-resources-html: Failed to clean project: Failed to delete C:\_dev\git\quarkus\integration-tests\maven\target\test-classes\projects\multimodule-resources-classpath\html\target\classes -> [Help 1]

I am not sure that this is the same problem as on Linux. I could only tell if I had the logs from CI but it doesn't seem to collect files like integration-tests/maven/target/test-classes/projects/multimodule-resources-classpath/build-multimodule-resources-classpath.log

I'll focus on the failure I am seeing on Windows for now and I'll create an infra-issue to collect all **/target/**/*.log.

@geoand
Copy link
Contributor

geoand commented Jul 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants