Make sure that test callbacks always work on the proper test method #10675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famod
reviewed
Jul 13, 2020
test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
#10623
branch
3 times, most recently
from
9e439f2 to
ec45cc2
Compare
|
Interesting: This one test failure is the same DevMojo test that you disabled and I re-enabled, but this time it is on Ubuntu. |
|
Yeah, I think that test will be to be disabled completely... |
|
@stuartwdouglas mind taking a quick look please? Thanks! |
stuartwdouglas
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, the
testMethodofQuarkusTestMethodContextwas using the method of the original class - which was not of much use since for example annotations could not be fetched unless the callback itself resorted to classloader hacks.Furthermore, the callbacks were misbehaving when multiple test profiles were being used in the testsuite.
Fixes: #10623