Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra/CI: Archive **/target/**/*.log and maybe more #10696

Closed
famod opened this issue Jul 13, 2020 · 3 comments · Fixed by #14659
Closed

Infra/CI: Archive **/target/**/*.log and maybe more #10696

famod opened this issue Jul 13, 2020 · 3 comments · Fixed by #14659
Labels
area/infra internal and infrastructure related issues kind/enhancement New feature or request
Milestone
1.12.0.CR1

Comments

@famod
Copy link
Member

famod commented Jul 13, 2020 •
edited
Loading

Description
CI is currently not archiving all logs that are needed to analyze failures. E.g. in #10647 (comment) I am missing integration-tests/maven/target/test-classes/projects/multimodule-resources-classpath/build-multimodule-resources-classpath.log.
This is especially obstructive when flaky tests are involved and/or your local operating system differs from CI.

Implementation ideas
I propose to create for each build/job an archive (or add to the existing one) with all logfiles under target (however deeply nested).

Furthermore I propose to archive **/target/surefire-reports/* and **/target/failsafe-reports/*. Not sure about Gradle, though.

I also propose the set trimStackTrace to false for the entire repo.
See also: https://lists.apache.org/thread.html/r9030808273c82ac6d7b9602d34d446c7d8c4e8aa02c41bca164df1c5%40%3Cdev.maven.apache.org%3E (meaning that even the Maven maintainers suggest to disable it)
@famod famod added kind/enhancement New feature or request area/infra internal and infrastructure related issues labels Jul 13, 2020
@famod
Copy link
Member Author

famod commented Jul 14, 2020

/cc @gastaldi

@gsmet
Copy link
Member

gsmet commented Jul 15, 2020

Makes sense.

@famod
Copy link
Member Author

famod commented Jan 27, 2021

Update:

  • Surefire reports are being archived for a while now ✔️
  • I switched off trimStackTrace recently (except for independent-projects) ✔️

So the only thing left are those logfiles.

@famod famod mentioned this issue Jan 27, 2021
Merged
@ghost ghost added this to the 1.12 - master milestone Jan 28, 2021
ebullient pushed a commit that referenced this issue Jan 29, 2021
@famod @ebullient
CI: Also archive log files on failure
5153d98 
Fixes #10696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/infra internal and infrastructure related issues kind/enhancement New feature or request
Projects
None yet
Milestone
1.12.0.CR1
Development

Successfully merging a pull request may close this issue.

CI: Also archive log files on failure
2 participants
@gsmet @famod