Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codestarts phase 1: Allow extensions to influence newly generated apps #10372

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Codestarts phase 1: Allow extensions to influence newly generated apps #10372

merged 1 commit into from
Jul 31, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jun 30, 2020 •
edited
Loading

Part of #8134 and #8178

This code gives same level of functionalitty (even a bit more) as the current codegen using Codestarts and Qute

  • During phase 1 (and until the api is more stable), all the codestarts are embeded in quarkus (and not yet part of extensions)
  • Goal is to improve and validate the codestarts structure
  • codestarts are located in devtools/platform-descriptor-json/src/main/resources/bundled-codestarts (and codestarts)
  • It's possible to generate a set of Quarkus app (using the new codestarts) from CodestartProjectTest maven/gradle/kotlin/scala/java with or without example
  • It's also possible to try it with the mvn quarkus plugin:
mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=my-first-codestart \
    -Dextensions="resteasy, resteasy-jsonb" \
    -DplatformArtifactId="quarkus-bom" -DplatformVersion="999-SNAPSHOT" \
    -DcodestartsEnabled -DwithExampleCode

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jun 30, 2020
@ia3andy ia3andy requested review from maxandersen, aloubyansky and gastaldi and removed request for maxandersen June 30, 2020 13:50
@ia3andy ia3andy requested a review from mkouba June 30, 2020 14:15
@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 30, 2020

@mkouba I invited you if you want to have a look at the Qute part.

This was referenced Jul 1, 2020
Closed
Closed
@ia3andy ia3andy changed the title Codestarts phase 1 draft Codestarts phase 1 Jul 1, 2020
@ia3andy ia3andy force-pushed the codestarts-v0 branch 2 times, most recently from fcb8f61 to 84ac8d8 Compare July 7, 2020 10:34
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 7, 2020 •
edited
Loading

@quarkusio/devtools the doc is available: https://github.com/ia3andy/quarkus/blob/codestarts-v0/independent-projects/tools/codestarts/codestarts.adoc

@ia3andy ia3andy force-pushed the codestarts-v0 branch 7 times, most recently from b5b0e7a to 67cf27a Compare July 7, 2020 14:23
@ia3andy ia3andy force-pushed the codestarts-v0 branch 2 times, most recently from b6f3846 to 33ef9b5 Compare July 30, 2020 07:11
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 30, 2020

with 1.7.cr1 looming I think we should get this in ASAP if no objections. the critical issues I've raised have been handled afaics and the remaining we can iterate over.

CI test errors should be fixed now and I've applied requested changes for everything that was quick to do.

This was referenced Jul 30, 2020
Closed
Closed
Closed
@ia3andy ia3andy force-pushed the codestarts-v0 branch 3 times, most recently from 8fe8932 to c05d618 Compare July 30, 2020 10:19
maxandersen
maxandersen approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm when/if CI passes

maxandersen
maxandersen approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm when/if CI passes

@gsmet gsmet dismissed their stale review July 30, 2020 13:59

Has been squashed.

@gsmet gsmet removed this from the 1.7.0.CR1 - master milestone Jul 30, 2020
@ia3andy ia3andy force-pushed the codestarts-v0 branch 3 times, most recently from f9bcdd8 to 51650ad Compare July 30, 2020 19:15
@ia3andy ia3andy added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 30, 2020
@gsmet
Copy link
Member

gsmet commented Jul 30, 2020

I will check tomorrow CI status and decide then if it can be included in CR1.

@ia3andy ia3andy force-pushed the codestarts-v0 branch 2 times, most recently from 1582b2c to 196f994 Compare July 31, 2020 05:26
@ia3andy
Introduce Codestarts
0577164 
Part of quarkusio#8134 and quarkusio#8178

Copying a few lines of code from `ClassPathUtils.processAsPath`

Various tidy ups

Add qute-example codestart and change naming convention

Improve integration tests

Use descriptive processors for codestarts
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 31, 2020 •
edited
Loading

@gsmet I had to rebase because #11098 has been merged and changed a behavior, had to update the test. It should be fine now:
inverted:

AbstractAddExtensionsTest:addExtensionsWhenMultipleMatchWithOneKeyword -> doesNotAddExtensionsWhenMultipleMatchWithOneKeyword

@gsmet gsmet merged commit 59043de into quarkusio:master Jul 31, 2020
@gsmet gsmet added this to the 1.7.0.CR1 milestone Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky left review comments

@maxandersen maxandersen maxandersen approved these changes

@gsmet gsmet gsmet left review comments

@mkouba mkouba Awaiting requested review from mkouba

@gastaldi gastaldi Awaiting requested review from gastaldi

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@ia3andy @maxandersen @gsmet @gastaldi @aloubyansky