-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid installing multiple extensions with multiple matches #11098
Conversation
2df5814
to
77dac54
Compare
edd0d7a
to
06a5b5f
Compare
Unless it's a pattern. Fixes quarkusio#11086
06a5b5f
to
afa209e
Compare
I thought we had tests for that? I remember we did tests some of this. |
@maxandersen can you check that one tomorrow morning? That's something I could include in the CR1. |
@ia3andy @gastaldi I assume this code only effects if you enable new registry ? Since default users are not affected in master where I get:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only affects new registry and looks correct thus lgtm.
Thanks, but looking at the output you pasted it seems like you're testing 1.6.1.Final. FYI the original extension lookup algorithm was copied to the extension registry and that's what's being used in the list and add-extension commands, regardless if the Registry URL is specified or not (it falls-back to the extensions in the platform if the registry URL is not provided). This was a special case that was not caught in the existing tests but hopefully this should be good now |
Unless it's a pattern.
Fixes #11086