Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle config conflict properly in Codestarts #11083

Closed
ia3andy opened this issue Jul 30, 2020 · 2 comments
Closed

Handle config conflict properly in Codestarts #11083

ia3andy opened this issue Jul 30, 2020 · 2 comments
Assignees
@ia3andy
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Jul 30, 2020

what happens if two extensions list the same key ? warning, error, nothing ?

Originally posted by @maxandersen in #10372 (comment)
@ia3andy ia3andy mentioned this issue Jul 30, 2020
Merged
@ia3andy ia3andy self-assigned this Jul 30, 2020
@ia3andy ia3andy added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jul 30, 2020
@geoand geoand added the kind/bug Something isn't working label Jul 30, 2020
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 31, 2020

part of #8134

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 15, 2021

Config conflicts are merged, so we don't fail, depending on the order of the extensions, one will override the other.

Being careful during code review should be enough to prevent problems.

@ia3andy ia3andy closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ia3andy ia3andy

Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ia3andy @geoand