Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knative manifest now uses valid port names #10370

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Knative manifest now uses valid port names #10370

merged 2 commits into from
Jul 1, 2020

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jun 30, 2020 •
edited by gsmet
Loading

Resolves #10332
Resolves #10260

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Jun 30, 2020
@iocanel iocanel requested a review from geoand June 30, 2020 13:21
@iocanel iocanel linked an issue Jun 30, 2020 that may be closed by this pull request
quarkus.kubernetes.annotations gets not applied to ingress #10260
Closed
@iocanel
Copy link
Contributor Author

iocanel commented Jun 30, 2020

@geoand: since the bump fixes more than a single issue. I added two more test cases just to verify that we also address #10260. You might want to have a second look.

@gsmet
Copy link
Member

gsmet commented Jun 30, 2020

All the JVM tests have failed so there's probably something wrong.

@geoand
Copy link
Contributor

geoand commented Jul 1, 2020

@gsmet I am going to mark this for backport since it's purely bug fixes

@gsmet gsmet changed the title fix (#10332): Knative manifest now uses valid port names. Knative manifest now uses valid port names Jul 1, 2020
@geoand geoand merged commit 547badd into quarkusio:master Jul 1, 2020
@gsmet gsmet added this to the 1.6.0.Final milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Milestone
1.6.0.Final
3 participants
@iocanel @gsmet @geoand