Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated knative.yaml does not work on Openshift Serverless #10332

Closed
geoand opened this issue Jun 29, 2020 · 1 comment · Fixed by #10370
Closed

Generated knative.yaml does not work on Openshift Serverless #10332

geoand opened this issue Jun 29, 2020 · 1 comment · Fixed by #10370
Assignees
@iocanel
Labels
area/kubernetes kind/bug Something isn't working
Milestone
1.6.0.Final

Comments

@geoand
Copy link
Contributor

geoand commented Jun 29, 2020

Describe the bug
When using the quarkus-kubernetes extension and quarkus.kubernetes.deployment-target=knative, the generated manifest cannot be applied to an Openshift Cluster with Openshift Serverless installed.

Expected behavior
The auto-generated manifests work OOTB on Openshift Serverless

Actual behavior
When applying the manifests as produced by the Kubernetes extension, we get:

Error from server (BadRequest): error when creating "target/kubernetes/knative.json": admission webhook "validation.webhook.serving.knative.dev" denied the request: validation failed: Port name http is not allowed: spec.template.spec.containers[0].ports
Name must be empty, or one of: 'h2c', 'http1'

However, if we remove the ports section inside the container, the manifest gets applied properly.
@geoand geoand added kind/bug Something isn't working area/kubernetes labels Jun 29, 2020
@geoand
Copy link
Contributor Author

geoand commented Jun 29, 2020

Seems related to #8659

@snowdrop-bot snowdrop-bot mentioned this issue Jun 30, 2020
Closed
iocanel added a commit to iocanel/quarkus that referenced this issue Jun 30, 2020
@iocanel
fix (quarkusio#10332): Knative manifest now uses valid port names.
657fedb
iocanel added a commit to iocanel/quarkus that referenced this issue Jun 30, 2020
@iocanel
fix (quarkusio#10332): Knative manifest now uses valid port names.
01697f1
@iocanel iocanel mentioned this issue Jun 30, 2020
Merged
iocanel added a commit to iocanel/quarkus that referenced this issue Jun 30, 2020
@iocanel
fix (quarkusio#10332): Knative manifest now uses valid port names.
f4af52f
iocanel added a commit to iocanel/quarkus that referenced this issue Jun 30, 2020
@iocanel
fix (quarkusio#10332): Knative manifest now uses valid port names.
9abd105
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 1, 2020
@iocanel @gsmet
fix (quarkusio#10332): Knative manifest now uses valid port names.
f63903d
@gsmet gsmet added this to the 1.6.0.Final milestone Jul 2, 2020
@iocanel iocanel mentioned this issue Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iocanel iocanel

Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Milestone
1.6.0.Final
Development

Successfully merging a pull request may close this issue.

Knative manifest now uses valid port names iocanel/quarkus
3 participants
@iocanel @gsmet @geoand