SSL support for reactive DB2 client #10620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Jul 10, 2020
| @@ -71,6 +73,9 @@ ServiceStartBuildItem build(BuildProducer<FeatureBuildItem> feature, | |||
| boolean isDefault = true; // assume always the default pool for now | |||
| vertxPool.produce(new VertxPoolBuildItem(db2PoolValue, DatabaseKind.DB2, isDefault)); | |||
|
|
|||
| // Enable SSL support by default | |||
| sslNativeSupport.produce(new ExtensionSslNativeSupportBuildItem(Feature.REACTIVE_DB2_CLIENT)); | |||
There was a problem hiding this comment.
I wonder if DataSourceReactiveDB2Config shouldn't be a build-time config. Then this would only be produced only if ssl is enabled
gastaldi
approved these changes
Jul 10, 2020
crissi98
pushed a commit
to crissi98/quarkus
that referenced
this pull request
Jul 10, 2020
matejvasek
pushed a commit
to matejvasek/quarkus
that referenced
this pull request
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10582