-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy Config-related cleanups #5388
Comments
@dmlloyd Is this issue fixed now? I was planning to work on it. |
@ShubhamRwt - the issue is mostly done but the PR (#5489) is out of date and needs a rebase. The original contributor gave up in frustration (this was really our fault) but if you want to start with that commit, rebase it and bring it up to date (and add yourself as |
Ok @dmlloyd. I will rebase it and send a new PR. |
Thanks @ShubhamRwt |
Hello @dmlloyd @machi1990 . The previous guy has made some unwanted changes due to which the build is failing. Should I create a new Pull request and make the only required changes? |
Go ahead. I'd recommend fixing just one problem per PR at a time; that will make it more likely to get merged quickly and hopefully avoid the troubles that the previous contributor encountered. |
Yes Sure. That would be great |
@machi1990 I went through the code base but seems like the second part is already resolved. Actually I was stuck with job work lately thats why this didn't got time for the rest over part but I will get it done and sorry for the delay. |
I will be proceeding with the 3rd pointer mentioned above tomorrow. |
@ShubhamRwt thanks for the update. No rush, and take your time. |
Hi. I would like to contribute to the project. It seems like there are two unresolved problems yet, right? |
Hi @dmlloyd, @machi1990, |
Thanks for the PR @adrianfiedler I'll have a look later today. |
Description
After #5387, there are several configuration constructs that can be cleaned up in core and extensions.
@ConfigItem
which has a primitive type likeint
orboolean
that has an explicit default value of0
orfalse
can have the default value removed.@ConfigItem
with a primitive wrapper type likeInteger
orBoolean
with an explicit default value of0
orfalse
should be changed to use the primitive type instead and remove the default value.@ConfigItem
of typeOptional<Integer>
can be changed toOptionalInt
.@ConfigItem
which is aList
type that is always converted to an array usingtoArray
can be changed to just be an array type instead.The text was updated successfully, but these errors were encountered: