Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all @ConfigItem of type Optional<Integer> to OptionalInt #10440

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Replace all @ConfigItem of type Optional<Integer> to OptionalInt #10440

merged 1 commit into from
Jul 4, 2020

Conversation

adrianfiedler
Copy link
Contributor

@adrianfiedler adrianfiedler commented Jul 2, 2020 •
edited by gsmet
Loading

Fixes #5388

@adrianfiedler adrianfiedler mentioned this pull request Jul 2, 2020
Closed
4 tasks
@adrianfiedler adrianfiedler changed the title Fixes #5388 Replace all @ConfigItem of type Optional<Integer> to OptionalInt WIP: Fixes #5388 Replace all @ConfigItem of type Optional<Integer> to OptionalInt Jul 2, 2020
@gastaldi
Copy link
Contributor

gastaldi commented Jul 3, 2020

LGTM, feel free to remove the WIP: from the PR title to kick CI

@adrianfiedler adrianfiedler changed the title WIP: Fixes #5388 Replace all @ConfigItem of type Optional<Integer> to OptionalInt Fixes #5388 Replace all @ConfigItem of type Optional<Integer> to OptionalInt Jul 3, 2020
@gsmet gsmet changed the title Fixes #5388 Replace all @ConfigItem of type Optional<Integer> to OptionalInt Replace all @ConfigItem of type Optional<Integer> to OptionalInt Jul 3, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 3, 2020
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 3, 2020
@gsmet gsmet merged commit 1e33ba6 into quarkusio:master Jul 4, 2020
@gsmet
Copy link
Member

gsmet commented Jul 4, 2020

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/jaeger area/kubernetes area/oidc triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Easy Config-related cleanups
4 participants
@adrianfiedler @gastaldi @gsmet @machi1990