Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easy Config-related cleanups #5388 #8497

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Easy Config-related cleanups #5388 #8497

merged 1 commit into from
Apr 24, 2020

Conversation

ShubhamRwt
Copy link
Contributor

Fixes correspondoing to first problem listed in #5388

@geoand
Copy link
Contributor

geoand commented Apr 9, 2020

Hi,

Thanks a lot for the PR!
Can you please squash the commits into a single one?

@ShubhamRwt
Copy link
Contributor Author

Yes sure @geoand ,On it.

@ShubhamRwt
Copy link
Contributor Author

@geoand I have squashed the commits. There were 4 problems listed in issue #5388 . I will be sending separate PRs for each problem as suggested by @dmlloyd

@geoand
Copy link
Contributor

geoand commented Apr 9, 2020

Good idea, thanks!

geoand
geoand approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @gsmet want to take a quick look as well?

machi1990
machi1990 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ShubhamRwt

@gsmet
Copy link
Member

gsmet commented Apr 24, 2020

I rebased and force pushed.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 24, 2020
@gsmet gsmet added this to the 1.5.0 milestone Apr 24, 2020
@machi1990 machi1990 merged commit ce8bd8c into quarkusio:master Apr 24, 2020
@machi1990
Copy link
Member

Merged. Thanks @ShubhamRwt

@machi1990
Copy link
Member

Fixes correspondoing to first problem listed in #5388

@ShubhamRwt do you want to take a look at the remaining parts listed in the issue
#5388?

@machi1990 machi1990 mentioned this pull request Apr 24, 2020
Closed
@ShubhamRwt
Copy link
Contributor Author

@machi1990 Yes. I will send it by tomorrow.

@machi1990
Copy link
Member

machi1990 commented Apr 25, 2020 •
edited
Loading

Great, thanks @ShubhamRwt let me know when you'll need a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/infinispan Infinispan area/kubernetes area/logging area/mongodb area/neo4j area/reactive-messaging area/resteasy-classic area/scheduler area/security area/smallrye triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.5.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@ShubhamRwt @geoand @gsmet @machi1990