Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ConfigMapping not working in 2.4.0.Final, but works in 2.3.1.Final #20916

Closed
snazy opened this issue Oct 20, 2021 · 2 comments · Fixed by #20940 or projectnessie/nessie#2471
Closed

@ConfigMapping not working in 2.4.0.Final, but works in 2.3.1.Final #20916

snazy opened this issue Oct 20, 2021 · 2 comments · Fixed by #20940 or projectnessie/nessie#2471
Labels
area/config kind/bug Something isn't working
Milestone

Comments

@snazy
Copy link
Contributor

snazy commented Oct 20, 2021

Describe the bug

We hit the @ConfigMapping vs. @ConfigProperties when the config's "statically" injected issue again with 2.4.0.Final.

dependabot-bump-PR run with code that works w/ Quarlus 2.3.1.Final. Related to #20103

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

  1. Clone projectnessie/nessie@18ca21d (or from a saved branch with the same commits at snazy/nessie@18ca21d)
  2. Run ':/mvnw -am -pl servers/quarkus-server -DskipTests`

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.4.0.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@radcortez
Copy link
Member

Having a look

@radcortez
Copy link
Member

This actually seems related to the optimization done in #19965.

The unused validation is only checking for the actual annotated class, but in this case, the injection point is using a parent class. I'll work on a fix.

Sorry for the inconvenience.

@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 25, 2021
@gsmet gsmet modified the milestones: 2.5 - main, 2.4.1.Final Nov 2, 2021
snazy added a commit to projectnessie/nessie that referenced this issue Nov 3, 2021
* Bump Quarkus version from 2.4.0.Final to 2.4.1.Final

Pulls in quarkusio/quarkus#20940
to fix quarkusio/quarkus#20916
and quarkusio/quarkus#20917

* Revert config-type workaround for Quarkus 2.4.0

* Revert config-mapping workaround for Quarkus 2.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/bug Something isn't working
Projects
None yet
4 participants