Do not validate configs in unused beans #19965

radcortez · 2021-09-07T12:42:01Z

This removes config validations and registrations of mappings / properties if the beans are unused. This may break existent applications if they only use programmatic lookups. In this case, mappings / properties need to be annotated with @Unremoveable or use the arc config to not remove beans.

quarkus-bot · 2021-09-07T16:32:26Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `66e48fc`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java

mkouba

I've added one minor comment. Otherwise looks good!

quarkus-bot · 2021-09-08T19:11:38Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `75043a5`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

mikethecalamity · 2021-09-22T08:11:10Z

Will this make it into 2.3?

radcortez · 2021-09-22T10:32:41Z

Will this make it into 2.3?

Yes. I need to update this for something else and it should be good to go.

quarkus-bot · 2021-09-23T16:00:05Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `ea0adf2`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-validator/deployment 
! Skipped: docs extensions/agroal/deployment extensions/apicurio-registry-avro/deployment and 187 more

📦 extensions/hibernate-validator/deployment

✖ io.quarkus.hibernate.validator.test.config.ConfigMappingValidatorTest.validator line 31 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: validator.server.host must be less than or equal to 3 ==> Unexpected exception type thrown ==> expected: <io.smallrye.config.ConfigValidationException> but was: <java.util.NoSuchElementException>
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:65)
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:41)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/hibernate-validator/deployment 
! Skipped: docs extensions/agroal/deployment extensions/apicurio-registry-avro/deployment and 187 more

📦 extensions/hibernate-validator/deployment

✖ io.quarkus.hibernate.validator.test.config.ConfigMappingValidatorTest.validator line 31 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: validator.server.host must be less than or equal to 3 ==> Unexpected exception type thrown ==> expected: <io.smallrye.config.ConfigValidationException> but was: <java.util.NoSuchElementException>
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:65)
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:41)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/hibernate-validator/deployment 
! Skipped: docs extensions/agroal/deployment extensions/apicurio-registry-avro/deployment and 187 more

📦 extensions/hibernate-validator/deployment

✖ io.quarkus.hibernate.validator.test.config.ConfigMappingValidatorTest.validator line 31 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: validator.server.host must be less than or equal to 3 ==> Unexpected exception type thrown ==> expected: <io.smallrye.config.ConfigValidationException> but was: <java.util.NoSuchElementException>
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:65)
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:41)

quarkus-bot · 2021-09-23T21:16:21Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `4b42c1f`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

mkouba · 2021-09-29T08:57:50Z

There are some conflicting files. @radcortez Could you resolve the conflicts first? I will need to check out the PR locally because the list of changes is quite long...

radcortez · 2021-09-29T13:40:53Z

There are some conflicting files. @radcortez Could you resolve the conflicts first? I will need to check out the PR locally because the list of changes is quite long...

Done. The additional changes are to cover @ConfigMapping and @ConfigProperties usages.

quarkus-bot · 2021-09-29T17:55:31Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `727920a`

Status	Name	Step	Failures	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java

radcortez · 2021-10-01T13:25:30Z

@mkouba thanks for the review. I've tried to address all the comments.

quarkus-bot · 2021-10-06T20:29:47Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `6378f80`

Status	Name	Step	Failures	Logs	Raw logs
✖	Native Tests - Data1	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Data1 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

✖ io.quarkus.it.hibernate.multitenancy.inventory.HibernateNamedPersistenceUnitTestInGraalITCase.testGetPlanesDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <200> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.inventory.HibernateNamedPersistenceUnitTestInGraalITCase.testGetPlanesTenantMycompany - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <200> but was <500>.

mkouba

Looks good.

radcortez · 2021-10-07T13:54:33Z

Thanks! Sorry for the bumps!

mikethecalamity · 2021-10-08T12:16:21Z

@radcortez any chance this will be in 2.3.1?

radcortez · 2021-10-08T15:58:41Z

Not likely, but 2.4.0 is not far. I'm sorry for the inconvenience :(

quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 7, 2021

mkouba reviewed Sep 8, 2021

View reviewed changes

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java Outdated Show resolved Hide resolved

mkouba reviewed Sep 8, 2021

View reviewed changes

radcortez force-pushed the fix-19388 branch from 66e48fc to 75043a5 Compare September 8, 2021 15:36

radcortez mentioned this pull request Sep 21, 2021

Allow to disable MP ConfigProperties and ConfigMapping #20275

Closed

radcortez force-pushed the fix-19388 branch from 75043a5 to ea0adf2 Compare September 23, 2021 13:54

radcortez mentioned this pull request Sep 23, 2021

Allow to disable MP ConfigProperties and ConfigMapping #20276

Closed

radcortez force-pushed the fix-19388 branch from ea0adf2 to 4b42c1f Compare September 23, 2021 17:06

quarkus-bot bot added the area/hibernate-validator Hibernate Validator label Sep 23, 2021

radcortez requested a review from mkouba September 24, 2021 15:33

radcortez force-pushed the fix-19388 branch from 4b42c1f to 727920a Compare September 29, 2021 13:39

quarkus-bot bot added area/config area/core labels Sep 29, 2021

mkouba reviewed Oct 1, 2021

View reviewed changes

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java Outdated Show resolved Hide resolved

mkouba reviewed Oct 1, 2021

View reviewed changes

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java Show resolved Hide resolved

mkouba reviewed Oct 1, 2021

View reviewed changes

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java Outdated Show resolved Hide resolved

mkouba reviewed Oct 1, 2021

View reviewed changes

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java Outdated Show resolved Hide resolved

radcortez force-pushed the fix-19388 branch from 727920a to 9f5080b Compare October 1, 2021 13:23

Do not validate configs in unused beans

6378f80

radcortez force-pushed the fix-19388 branch from 9f5080b to 6378f80 Compare October 6, 2021 15:32

radcortez requested a review from mkouba October 6, 2021 15:42

mkouba approved these changes Oct 7, 2021

View reviewed changes

radcortez merged commit 0d75ec1 into quarkusio:main Oct 7, 2021

quarkus-bot bot added this to the 2.4 - main milestone Oct 7, 2021

radcortez mentioned this pull request Oct 21, 2021

@ConfigMapping not working in 2.4.0.Final, but works in 2.3.1.Final #20916

Closed

radcortez mentioned this pull request Sep 15, 2022

Remove the deprecated io.quarkus.arc.config.ConfigProperties #22101

Closed

Do not validate configs in unused beans #19965

Do not validate configs in unused beans #19965

Conversation

radcortez commented Sep 7, 2021 • edited Loading

quarkus-bot bot commented Sep 7, 2021 • edited Loading

Failing Jobs - Building 66e48fc

Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

mkouba left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 8, 2021 • edited Loading

Failing Jobs - Building 75043a5

Failures

⚙️ JVM Tests - JDK 16 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

mikethecalamity commented Sep 22, 2021

radcortez commented Sep 22, 2021

quarkus-bot bot commented Sep 23, 2021 • edited Loading

Failing Jobs - Building ea0adf2

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-validator/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/hibernate-validator/deployment

⚙️ JVM Tests - JDK 17 #

📦 extensions/hibernate-validator/deployment

quarkus-bot bot commented Sep 23, 2021 • edited Loading

Failing Jobs - Building 4b42c1f

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

mkouba commented Sep 29, 2021

radcortez commented Sep 29, 2021

quarkus-bot bot commented Sep 29, 2021 • edited Loading

Failing Jobs - Building 727920a

radcortez commented Oct 1, 2021

quarkus-bot bot commented Oct 6, 2021 • edited Loading

Failing Jobs - Building 6378f80

Failures

⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

mkouba left a comment

Choose a reason for hiding this comment

radcortez commented Oct 7, 2021

mikethecalamity commented Oct 8, 2021

radcortez commented Oct 8, 2021

radcortez commented Sep 7, 2021 •

edited

Loading

quarkus-bot bot commented Sep 7, 2021 •

edited

Loading

Failing Jobs - Building `66e48fc`

quarkus-bot bot commented Sep 8, 2021 •

edited

Loading

Failing Jobs - Building `75043a5`

quarkus-bot bot commented Sep 23, 2021 •

edited

Loading

Failing Jobs - Building `ea0adf2`

quarkus-bot bot commented Sep 23, 2021 •

edited

Loading

Failing Jobs - Building `4b42c1f`

quarkus-bot bot commented Sep 29, 2021 •

edited

Loading

Failing Jobs - Building `727920a`

quarkus-bot bot commented Oct 6, 2021 •

edited

Loading

Failing Jobs - Building `6378f80`