Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency not resolved (new in 2.4.0.Final, works in 2.3.1.Final) #20917

Closed
snazy opened this issue Oct 20, 2021 · 2 comments · Fixed by #20940
Closed

Dependency not resolved (new in 2.4.0.Final, works in 2.3.1.Final) #20917

snazy opened this issue Oct 20, 2021 · 2 comments · Fixed by #20940
Labels
area/bootstrap kind/bug Something isn't working
Milestone
2.4.1.Final

Comments

@snazy
Copy link
Contributor

snazy commented Oct 20, 2021 •
edited
Loading

Describe the bug

In this file we have a dependency to the interface NonTransactionalDatabaseAdapterConfig, which is implemented by QuarkusVersionStoreAdvancedConfig.

If I change the dependency as in this commit, the dependency's correctly resolved.

It doesn't matter whether the dependency is injected via the constructor or via a field.

The same code works with Quarkus 2.3.1.Final. dependabot-bump-PR run with code that works w/ Quarlus 2.3.1.Final.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

  1. Clone projectnessie/nessie@18ca21d (or from a saved branch with the same commits at snazy/nessie@18ca21d)
  2. Run ':/mvnw -am -pl servers/quarkus-server -DskipTests`

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@snazy snazy added the kind/bug Something isn't working label Oct 20, 2021
@snazy snazy mentioned this issue Oct 20, 2021
Merged
snazy added a commit to snazy/nessie that referenced this issue Oct 22, 2021
@snazy
Bump Quarkus version from 2.4.0.Final to 2.4.1.Final
cdc6c15 
Pulls in quarkusio/quarkus#20940
to fix quarkusio/quarkus#20916
and quarkusio/quarkus#20917
@snazy snazy mentioned this issue Oct 22, 2021
Merged
@famod
Copy link
Member

famod commented Oct 23, 2021

/cc @aloubyansky

@famod
Copy link
Member

famod commented Oct 23, 2021

It seems this is fixed by #20940, according to #20940 (review)

/cc @radcortez

@geoand geoand mentioned this issue Oct 25, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 25, 2021
@gsmet gsmet modified the milestones: 2.5 - main, 2.4.1.Final Nov 2, 2021
snazy added a commit to snazy/nessie that referenced this issue Nov 3, 2021
@snazy
Bump Quarkus version from 2.4.0.Final to 2.4.1.Final
604d83f 
Pulls in quarkusio/quarkus#20940
to fix quarkusio/quarkus#20916
and quarkusio/quarkus#20917
snazy added a commit to snazy/nessie that referenced this issue Nov 3, 2021
@snazy
Bump Quarkus version from 2.4.0.Final to 2.4.1.Final
e7fc103 
Pulls in quarkusio/quarkus#20940
to fix quarkusio/quarkus#20916
and quarkusio/quarkus#20917
snazy added a commit to projectnessie/nessie that referenced this issue Nov 3, 2021
@snazy
Bump Quarkus version from 2.4.0.Final to 2.4.1.Final (#2471)
44bd5c4 
* Bump Quarkus version from 2.4.0.Final to 2.4.1.Final

Pulls in quarkusio/quarkus#20940
to fix quarkusio/quarkus#20916
and quarkusio/quarkus#20917

* Revert config-type workaround for Quarkus 2.4.0

* Revert config-mapping workaround for Quarkus 2.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/bootstrap kind/bug Something isn't working
Projects
None yet
Milestone
2.4.1.Final
Development

Successfully merging a pull request may close this issue.

Validate full hierarchy of ConfigMapping injection points radcortez/quarkus
4 participants
@snazy @gsmet @geoand @famod