Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag with JIRA ticket to 3.2.9 test coverage #1538

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add tag with JIRA ticket to 3.2.9 test coverage #1538

merged 1 commit into from
Nov 22, 2023

Conversation

michalvavrik
Copy link
Member

Summary

Add tags for:

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from jedla97 November 21, 2023 18:25
@michalvavrik michalvavrik added the triage/backport-3.2 RHBQ Ghost LTS release label Nov 21, 2023
jedla97
jedla97 reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good just that one thing. It's not necessary I'm fine with both way but maybe your thoughts on this.

...-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/BaseHttpAdvancedReactiveIT.java Outdated Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/add-tags-3-2-9-coveregate branch from f171658 to 92cac52 Compare November 21, 2023 23:32
@michalvavrik michalvavrik requested a review from jedla97 November 21, 2023 23:33
jedla97
jedla97 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks good!

@jedla97 jedla97 merged commit 22c83cc into quarkus-qe:main Nov 22, 2023
7 checks passed
@michalvavrik michalvavrik deleted the feature/add-tags-3-2-9-coveregate branch November 22, 2023 11:09
@michalvavrik michalvavrik mentioned this pull request Nov 23, 2023
Merged
9 tasks
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedla97 jedla97 jedla97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @jedla97