Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for QuarkusSecurityTestExtension callbacks #1515

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add tests for QuarkusSecurityTestExtension callbacks #1515

merged 1 commit into from
Nov 10, 2023

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 10, 2023

Related to issue quarkusio/quarkus#36601.

Summary

Create test that tests when QuarkusSecurityTestExtension.beforeEach and afterEach executes @TestSecurity related behaviour.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

looks probably ok, I need to re-check later when I'm in train, thx

@michalvavrik michalvavrik added the triage/backport-3.2 RHBQ Ghost LTS release label Nov 10, 2023
michalvavrik
michalvavrik approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michalvavrik michalvavrik merged commit 764e0f6 into quarkus-qe:main Nov 10, 2023
7 checks passed
@mocenas mocenas deleted the security_after_each branch November 13, 2023 08:06
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Nov 21, 2023
This was referenced Nov 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees

@michalvavrik michalvavrik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mocenas @michalvavrik