Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2] Backport gRPC interceptor test coverage and tagging tests with JIRAs #1541

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[3.2] Backport gRPC interceptor test coverage and tagging tests with JIRAs #1541

merged 2 commits into from
Nov 23, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 23, 2023 •
edited
Loading

Summary

Backports:

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mocenas November 23, 2023 13:27
mocenas
mocenas approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I see no issues.

@michalvavrik michalvavrik merged commit dfeaf55 into quarkus-qe:3.2 Nov 23, 2023
6 checks passed
@michalvavrik michalvavrik deleted the backports/3.2.9-second branch November 23, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocenas mocenas mocenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalvavrik @mocenas @jedla97