Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QDType bit interfaces for classical simulation #1215

Merged

Conversation

anurudhp
Copy link
Contributor

Final part of #1142!

  • Remove classical sim ints_to_bits and bits_to_ints, and always use QDType bit interfaces (from_bits, to_bits etc.).
  • Update all bookeeping bloqs to use the QDType bit features.

Fixes #811
Fixes #606
Fixes #643

@mpharrigan
Copy link
Collaborator

Since this will close all those bugs, can you open a bug for classical simulation of fixed point. A brief overview of the current situation where you pass around ints because of deficiencies in fxpmath; and potential alternatives going forward

@anurudhp
Copy link
Contributor Author

Since this will close all those bugs, can you open a bug for classical simulation of fixed point. A brief overview of the current situation where you pass around ints because of deficiencies in fxpmath; and potential alternatives going forward

Done!

@anurudhp anurudhp enabled auto-merge (squash) July 30, 2024 23:57
@anurudhp anurudhp merged commit 0af54fc into quantumlib:main Jul 31, 2024
8 checks passed
@anurudhp anurudhp deleted the 2024/07/30-use-dtype-for-classical-sim branch July 31, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants