Refactor classical_sim.py
bitwise functions to allow for signed values
#606
Labels
classical_sim.py
bitwise functions to allow for signed values
#606
bits_to_ints()
andints_to_bits()
only work for conversions of unsigned integers. This limits the classical simulation correctness for bloqs usingJoin()
because itson_classical_vals()
implementation uses these functions. Therefore when we get the classical simulation of a bloq that usesJoin()
it cannot represent signed integers so we can't have tests for classical simulation of signed integer representations.Currently this affects the signed implementation of
Add()
and doesn't allow us to classically simulateSimpleAddConstant()
. Once this functionality has been changed we need to add tests for the classical simulation of the signed version ofSimpleAddConstant()
.The text was updated successfully, but these errors were encountered: