Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for QFxp in classical simulation #1095

Closed
NoureldinYosri opened this issue Jun 27, 2024 · 2 comments
Closed

Improve support for QFxp in classical simulation #1095

NoureldinYosri opened this issue Jun 27, 2024 · 2 comments
Labels
sim/classical

Comments

@NoureldinYosri
Copy link
Contributor

Classical simulation protocol assumes values are always integer as seen by the type hint

Qualtran/qualtran/simulation/classical_sim.py

Line 37 in c6aa419

ClassicalValT = Union[int, np.integer, NDArray[np.integer]]

however float values can happen when using QFxp dtype.
@NoureldinYosri NoureldinYosri mentioned this issue Jun 27, 2024
Merged
@fdmalone
Copy link
Collaborator

xref #859

@anurudhp
Copy link
Contributor

anurudhp commented Aug 1, 2024

#1215 adds support for QDType specific values, and #1219 can be used to track ideas for classical representations of QFxp values.

@anurudhp anurudhp closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sim/classical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NoureldinYosri @anurudhp @fdmalone