Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fxp classical simulation #859

Closed
wants to merge 48 commits into from

Conversation

fdmalone
Copy link
Collaborator

@fdmalone fdmalone commented Apr 4, 2024

Adds:

  • classical simulation for the Fxp multiplication bloqs + refactors the error analysis notebook to use these
  • Updates phase gradient classical simulation to use Fxp types
  • Uses correct QDType bit converters.

Problems:

  • Phase gradient tests are way too slow with Fxp classical simulation.

Built upon #817

@fdmalone fdmalone force-pushed the typed_classical_sim branch from d51ed56 to 3589c11 Compare April 10, 2024 22:34
@fdmalone fdmalone marked this pull request as ready for review April 10, 2024 22:38
@fdmalone
Copy link
Collaborator Author

cc @tanujkhattar, I need to profile why classical simulation is so slow + an alternative to caching BUT the big problem right now is that some of the tests which use the phasegradient have impossibly slow tests. Might be good to get the ball rolling though, was a painful PR. I can also split it up potentially since there are a few things going on.

@fdmalone
Copy link
Collaborator Author

My sneaking suspicion is doing the bitwise algorithm for the paper is slow, @tanujkhattar did you check if Fxp multiplication yielded the same thing as what's in the reference.

@fdmalone fdmalone changed the title [WIP] Add Fxp classical simulation Add Fxp classical simulation Apr 11, 2024
@fdmalone fdmalone closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant