-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fxp classical simulation #859
Conversation
…ualtran into propagate_split_dtype_to_join
Debugging. Tidy.
…ualtran into propagate_split_dtype_to_join
d51ed56
to
3589c11
Compare
cc @tanujkhattar, I need to profile why classical simulation is so slow + an alternative to caching BUT the big problem right now is that some of the tests which use the phasegradient have impossibly slow tests. Might be good to get the ball rolling though, was a painful PR. I can also split it up potentially since there are a few things going on. |
My sneaking suspicion is doing the bitwise algorithm for the paper is slow, @tanujkhattar did you check if Fxp multiplication yielded the same thing as what's in the reference. |
Adds:
Problems:
Built upon #817