New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

188 serialize outside lock #220

Merged

ikopylov merged 24 commits into master from 188-serialize-outside-lock

Feb 24, 2023

Contributor

idruzhitskiy commented Nov 22, 2022 •

edited

Loading

Closes #188
Closes #206
Closes #199


          use two-step serialization for records

fef8f20

idruzhitskiy requested a review from ikopylov

November 22, 2022 15:08

idruzhitskiy added 2 commits

November 22, 2022 18:41


          fix names for functions

e4e5cb7


          update changelog

80aba3d

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record.rs Outdated Show resolved Hide resolved

ikopylov added the required for release label

ikopylov mentioned this pull request

Partially fix data corruption due to canceling an asynchronous operation #228

Closed

Ivan Druzhitskiy added 8 commits

February 2, 2023 09:24


          Merge branch 'master' of github.com:qoollo/pearl into 188-serialize-o…

…utside-lock


          make new code work with master

b1a0f6b


          extract partial structures to another file

5e7307e


          refactor partially serialized header

d091898


          update offset functions

26fae57


          remove unnecessary fields

4fe5488


          fix parasite changes

8d488c8


          Revert "fix parasite changes"

8f869dc

This reverts commit 8d488c8.

ikopylov reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/blob/core.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/mod.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Outdated Show resolved Hide resolved

idruzhitskiy and others added 10 commits

February 8, 2023 12:48


          Update src/record/mod.rs

e3f91e7

Co-authored-by: ikopylov <[email protected]>


          Update src/record/mod.rs

cf144a2

Co-authored-by: ikopylov <[email protected]>


          fix serialization

27c96ea


          update changelog

14bc74e


          move record data to record.rs

e51ba7a


          fix header checksum

a8df219


          update test

8a9bdbf


          fix test

8b213d5


          Merge branch '188-serialize-outside-lock' of github.com:qoollo/pearl …

c018b6c

…into 188-serialize-outside-lock


          return size optimization

d82f525

ikopylov reviewed

View reviewed changes

src/record/record.rs Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/record.rs Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Outdated Show resolved Hide resolved

ikopylov reviewed

View reviewed changes

src/record/partially_serialized.rs Outdated Show resolved Hide resolved

Ivan Druzhitskiy added 2 commits

February 23, 2023 16:58


          fix discussions

8f77c80


          add test for serialization

eb453d3

ikopylov reviewed

View reviewed changes

src/record/record.rs Outdated Show resolved Hide resolved


          Update record.rs

e6901eb

ikopylov approved these changes

View reviewed changes

Member

ikopylov left a comment

LGTM

ikopylov merged commit 1ddec2d into master

ikopylov mentioned this pull request

Place lock on current_offset right before actual write to file in Pearl::Blob qoollo/bob#601

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

required for release