Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place lock on current_offset right before actual write to file in Blob #188

Closed
ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #220
Closed

Place lock on current_offset right before actual write to file in Blob #188

ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #220
Assignees
@idruzhitskiy
Labels
enhancement New feature or request performance

Comments

@ikopylov
Copy link
Member

Lock taken too early. First, serialization should be performed and only after that the lock should be taken.
https://github.com/qoollo/pearl/blob/master/src/blob/core.rs#L234

This will require offset patching, but should improve performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idruzhitskiy idruzhitskiy

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

188 serialize outside lock qoollo/pearl
2 participants
@ikopylov @idruzhitskiy