Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Blob::read_any to Blob::read_last #199

Closed
ikopylov opened this issue Sep 6, 2022 · 1 comment · Fixed by #220
Closed

Rename Blob::read_any to Blob::read_last #199

ikopylov opened this issue Sep 6, 2022 · 1 comment · Fixed by #220
Assignees
@idruzhitskiy
Labels
enhancement New feature or request

Comments

@ikopylov
Copy link
Member

ikopylov commented Sep 6, 2022 •
edited
Loading

In the current implementation, Blob::read_any actually reads the last record and we strongly depend on this behavior.
https://github.com/qoollo/pearl/blob/master/src/blob/core.rs#L255
@ikopylov ikopylov added the enhancement New feature or request label Sep 6, 2022
@ikopylov
Copy link
Member Author

ikopylov commented Sep 6, 2022 •
edited
Loading

Additionally, we should rename get_entry to get_last_entry

@idruzhitskiy idruzhitskiy mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idruzhitskiy idruzhitskiy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

188 serialize outside lock qoollo/pearl
2 participants
@ikopylov @idruzhitskiy