Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community layout support for KBDpad Mk.I #9220

Merged
merged 2 commits into from
May 28, 2020
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 27, 2020

Description

Thanks to NorrittMTG#1661 on Discord for pointing this out.
Apparently there is a new version of the KBDPad, confusingly called V2, but still has the ATmega32A of the MKI (the MKII uses a 32U2), as well as the same matrix layout. Google couldn't turn up anything on the original MKI but I think it can be reasonably assumed that they are for all intents and purposes the same PCB. Confirmed this is the same PCB from an unboxing video.

https://kbdfans.com/products/kbdfans-kbdpad-pcb-v2

This PCB supports more keys than the pictured case, in fact it can do a proper numpad_6x4 or ortho_6x4 layout...with some extra space between the top two rows. Not sure if that disqualifies it for those layouts, given there are the same number of keys, more or less in the same positions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both the numpad_6x4 and the ortho_6x4 layouts with NorrittMTG#1661.
With the latter, every key of the 6x4 matrix works.

@Erovia Erovia requested a review from a team May 27, 2020 18:11
@zvecr zvecr merged commit 13206b2 into qmk:master May 28, 2020
@fauxpark fauxpark deleted the kbdpad-new-layouts branch May 28, 2020 01:28
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
* upstream/master: (800 commits)
  Fix crkbd slave matrix print to require debug_matrix (qmk#9217)
  Keyboards/zsa updates (qmk#9214)
  Community layout support for KBDpad Mk.I (qmk#9220)
  Fix projectkb/alice LED indicator (qmk#9226)
  RSTHD keymap for Minidox (qmk#9178)
  Fix running qmk info without any arguments (qmk#9218)
  [Keymap] Update yttyx Planck keymap (qmk#9191)
  Documentation for keymap_extras (qmk#9194)
  Adding TGR Tris/Tris CE Numpad (qmk#9139)
  ISSI driver compile error fix (qmk#9169)
  Fix the path for generated keymaps (qmk#9213)
  Fix compiling json files (qmk#9210)
  [CLI] Add a subcommand for getting information about a keyboard (qmk#8666)
  [Keymap] Contributing Home-Row-Centric-Mousekey  Layout (qmk#9195)
  CLI: fix `json2c` subcommand and add/fix tests (qmk#9206)
  [Keymap] Ported ok60 to via (qmk#9179)
  [Docs] Japanese translation of docs/feature_pointing_device.md (qmk#8993)
  [Keymap] Niu keymap and README update (qmk#9190)
  [Keyboard] Add Key 65 by Fox Lab (qmk#9116)
  [Keymap] update helix/rev2:yshrsmz keymap (qmk#9047)
  ...
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Community layout support for KBDpad Mk.I

* Matching spacing
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Community layout support for KBDpad Mk.I

* Matching spacing
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* Community layout support for KBDpad Mk.I

* Matching spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants