-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running qmk info without any arguments #9218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't read/program in python worth a damn, but can confirm that this fixes the issue. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)is_keyboard
should return False
when the argument is not a keyboard.
* upstream/master: (800 commits) Fix crkbd slave matrix print to require debug_matrix (qmk#9217) Keyboards/zsa updates (qmk#9214) Community layout support for KBDpad Mk.I (qmk#9220) Fix projectkb/alice LED indicator (qmk#9226) RSTHD keymap for Minidox (qmk#9178) Fix running qmk info without any arguments (qmk#9218) [Keymap] Update yttyx Planck keymap (qmk#9191) Documentation for keymap_extras (qmk#9194) Adding TGR Tris/Tris CE Numpad (qmk#9139) ISSI driver compile error fix (qmk#9169) Fix the path for generated keymaps (qmk#9213) Fix compiling json files (qmk#9210) [CLI] Add a subcommand for getting information about a keyboard (qmk#8666) [Keymap] Contributing Home-Row-Centric-Mousekey Layout (qmk#9195) CLI: fix `json2c` subcommand and add/fix tests (qmk#9206) [Keymap] Ported ok60 to via (qmk#9179) [Docs] Japanese translation of docs/feature_pointing_device.md (qmk#8993) [Keymap] Niu keymap and README update (qmk#9190) [Keyboard] Add Key 65 by Fox Lab (qmk#9116) [Keymap] update helix/rev2:yshrsmz keymap (qmk#9047) ...
Description
Currently
qmk info
will crash if run without --keyboard. This fixes that.Types of Changes
Checklist