Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niu keymap and README update #9190

Merged
merged 5 commits into from
May 26, 2020
Merged

Niu keymap and README update #9190

merged 5 commits into from
May 26, 2020

Conversation

yttyx
Copy link
Contributor

@yttyx yttyx commented May 24, 2020

Description

Added steno layer. Finalised other layers following months of use. Tidied README file.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • [x ] Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Nick Willis added 4 commits May 22, 2020 21:37
- Added Plover layer
- Updated README to use layout images
- Link to new FC layer image from README
@drashna drashna requested a review from a team May 25, 2020 03:30
@drashna drashna added the keymap label May 25, 2020
keyboards/niu_mini/keymaps/yttyx/keymap.c Outdated Show resolved Hide resolved
keyboards/niu_mini/keymaps/yttyx/keymap.c Outdated Show resolved Hide resolved
@yttyx
Copy link
Contributor Author

yttyx commented May 25, 2020

Hi drashna and fauxpark - thank you for the review. Changes made. Regards, Nick.

@yttyx yttyx mentioned this pull request May 25, 2020
13 tasks
@noroadsleft noroadsleft merged commit bfe7605 into qmk:master May 26, 2020
@noroadsleft
Copy link
Member

Thanks!

nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
* upstream/master: (800 commits)
  Fix crkbd slave matrix print to require debug_matrix (qmk#9217)
  Keyboards/zsa updates (qmk#9214)
  Community layout support for KBDpad Mk.I (qmk#9220)
  Fix projectkb/alice LED indicator (qmk#9226)
  RSTHD keymap for Minidox (qmk#9178)
  Fix running qmk info without any arguments (qmk#9218)
  [Keymap] Update yttyx Planck keymap (qmk#9191)
  Documentation for keymap_extras (qmk#9194)
  Adding TGR Tris/Tris CE Numpad (qmk#9139)
  ISSI driver compile error fix (qmk#9169)
  Fix the path for generated keymaps (qmk#9213)
  Fix compiling json files (qmk#9210)
  [CLI] Add a subcommand for getting information about a keyboard (qmk#8666)
  [Keymap] Contributing Home-Row-Centric-Mousekey  Layout (qmk#9195)
  CLI: fix `json2c` subcommand and add/fix tests (qmk#9206)
  [Keymap] Ported ok60 to via (qmk#9179)
  [Docs] Japanese translation of docs/feature_pointing_device.md (qmk#8993)
  [Keymap] Niu keymap and README update (qmk#9190)
  [Keyboard] Add Key 65 by Fox Lab (qmk#9116)
  [Keymap] update helix/rev2:yshrsmz keymap (qmk#9047)
  ...
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* - Balance 12 layers now in their final form
- Added Plover layer
- Updated README to use layout images

* Add headings to layer images.

* - Remove redundent TO(_BA) from FC layer
- Link to new FC layer image from README

* Highlight home keys.

* Changes following review.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* - Balance 12 layers now in their final form
- Added Plover layer
- Updated README to use layout images

* Add headings to layer images.

* - Remove redundent TO(_BA) from FC layer
- Link to new FC layer image from README

* Highlight home keys.

* Changes following review.
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* - Balance 12 layers now in their final form
- Added Plover layer
- Updated README to use layout images

* Add headings to layer images.

* - Remove redundent TO(_BA) from FC layer
- Link to new FC layer image from README

* Highlight home keys.

* Changes following review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants