Fix my userspace RGB bug #5686
Merged
Fix my userspace RGB bug #5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Apr 26, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (99 commits) [Keyboard] Add a new keyboard ADKB96 (qmk#5685) test commit add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to rgblight_update_dword() add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to eeconfig_update_rgblight_default() Refactor cospad to current standards and enable support for backlight keycodes (qmk#5582) [Keymap] update (mouse emulation, rev 6 compatibility) (qmk#5696) [Keyboard] fix project zen rev1 bootloader declaration (qmk#5695) [FIX] Misspelled RGB_YELLOW (qmk#5692) [Keymap] Fix broken Shift-Insert binding (qmk#5689) [Keyboard] forgot to omit k05 from the electrical matrix in hhkb layout (qmk#5684) [Keyboard] Fix red an green leds location (qmk#5698) Translate docs into Chinese (qmk#5693) [Keymap] Fix my userspace RGB bug (qmk#5686) Boston meetup 2019 (qmk#5611) [Keymap] Update to Drashna Keymaps (qmk#5594) fix LIB_SRC and QUANTUM_LIB_SRC for ARM (qmk#5623) RGB Matrix Animations: Three/six new reactive effects (wide, cross, nexus) (qmk#5602) Fix qmk#3566 use an hardware timer for software PWM stability (qmk#3615) added info.json for ymd96 (qmk#4982) Define RGB colors (qmk#5300) ...
KauyonKais
pushed a commit
to KauyonKais/qmk_firmware
that referenced
this pull request
Apr 27, 2019
* fix bug that enabled RGBLIGHT_ENABLE on all my boards regardless if it was supported or not * update changelog with new changes for 0.2.2
foosinn
pushed a commit
to foosinn/qmk_firmware
that referenced
this pull request
May 6, 2019
* fix bug that enabled RGBLIGHT_ENABLE on all my boards regardless if it was supported or not * update changelog with new changes for 0.2.2
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* fix bug that enabled RGBLIGHT_ENABLE on all my boards regardless if it was supported or not * update changelog with new changes for 0.2.2
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
* fix bug that enabled RGBLIGHT_ENABLE on all my boards regardless if it was supported or not * update changelog with new changes for 0.2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out I was enabling RGBLIGHT_ENABLE on my boards regardless if there was a pin defined or not.
Types of Changes
Checklist