-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cospad to current standards and enable support for backlight keycodes #5582
Conversation
This was a deliberate choice because for gamepad usage, it's supposed to be landscape: Realistically, the layout macro should be 6 columns and 4 rows (physically; even though it says |
@noroadsleft I feel the name and layout Configurator should all correlate. From a conceptual point, rotating a board (where it makes sense) is something that could be entirely done in the Configurators UI. Given 1 keymap already exists in the repo, a good short term compromise could be to add both 6x4 and 4x6. However i will also back out the change if its the consensus. |
That's fair. I left the name because I would have had to edit additional files. I was comfortable doing that, but it wasn't relevant to my goal, so I left it alone. The macro could just leave off the layout dimensions (
That's exactly what I did Notice the first four keys are all If I had to do it again, I probably would rotate the layout macro and regenerate the
That would require editing the |
The rotated numpad is one of the reasons why I really wanted this board, unfortunately they don't actually sell that case anymore. By the time I decided I wanted one, it was sold out and the new and "improved" v2 was deemed the cospad case. On that note, depending on rotation, bootmagic lite key will change position. Can we change its location based on the LAYOUT_macro in use? @drashna |
@mechmerlin No, we can't. The best we can do is have a define that controls the bootmagic config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* 'master' of https://github.com/qmk/qmk_firmware: (99 commits) [Keyboard] Add a new keyboard ADKB96 (qmk#5685) test commit add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to rgblight_update_dword() add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to eeconfig_update_rgblight_default() Refactor cospad to current standards and enable support for backlight keycodes (qmk#5582) [Keymap] update (mouse emulation, rev 6 compatibility) (qmk#5696) [Keyboard] fix project zen rev1 bootloader declaration (qmk#5695) [FIX] Misspelled RGB_YELLOW (qmk#5692) [Keymap] Fix broken Shift-Insert binding (qmk#5689) [Keyboard] forgot to omit k05 from the electrical matrix in hhkb layout (qmk#5684) [Keyboard] Fix red an green leds location (qmk#5698) Translate docs into Chinese (qmk#5693) [Keymap] Fix my userspace RGB bug (qmk#5686) Boston meetup 2019 (qmk#5611) [Keymap] Update to Drashna Keymaps (qmk#5594) fix LIB_SRC and QUANTUM_LIB_SRC for ARM (qmk#5623) RGB Matrix Animations: Three/six new reactive effects (wide, cross, nexus) (qmk#5602) Fix qmk#3566 use an hardware timer for software PWM stability (qmk#3615) added info.json for ymd96 (qmk#4982) Define RGB colors (qmk#5300) ...
Description
Refactor staryu to current standards;
'#pragma once
Rotated
LAYOUT_gamepad_6x4
back to portrait in the Configurator to match the name and macro.Enable support for backlight keycodes;
Types of Changes
Checklist