-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix LIB_SRC and QUANTUM_LIB_SRC for ARM(chibios) #5623
Conversation
|
Hmmm, what should we do?
|
Don't worry about the demos in /lib/chibios - they aren't used and they're on a different repository anyway. |
@pelrun So far, the only boards that use ATSAM are the Massdrop boards (CTRL and ALT), but yes, they do need this fix applied as well. That said, @patrickmt any issue with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and compiles properly!
* fix LIB_SRC and QUANTUM_LIB_SRC for ARM(chibios) * remove ARFLAGS * tmk_core/arm_atsam.mk:AR: remove 'rcs'
* 'master' of https://github.com/qmk/qmk_firmware: (99 commits) [Keyboard] Add a new keyboard ADKB96 (qmk#5685) test commit add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to rgblight_update_dword() add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to eeconfig_update_rgblight_default() Refactor cospad to current standards and enable support for backlight keycodes (qmk#5582) [Keymap] update (mouse emulation, rev 6 compatibility) (qmk#5696) [Keyboard] fix project zen rev1 bootloader declaration (qmk#5695) [FIX] Misspelled RGB_YELLOW (qmk#5692) [Keymap] Fix broken Shift-Insert binding (qmk#5689) [Keyboard] forgot to omit k05 from the electrical matrix in hhkb layout (qmk#5684) [Keyboard] Fix red an green leds location (qmk#5698) Translate docs into Chinese (qmk#5693) [Keymap] Fix my userspace RGB bug (qmk#5686) Boston meetup 2019 (qmk#5611) [Keymap] Update to Drashna Keymaps (qmk#5594) fix LIB_SRC and QUANTUM_LIB_SRC for ARM (qmk#5623) RGB Matrix Animations: Three/six new reactive effects (wide, cross, nexus) (qmk#5602) Fix qmk#3566 use an hardware timer for software PWM stability (qmk#3615) added info.json for ymd96 (qmk#4982) Define RGB colors (qmk#5300) ...
* fix LIB_SRC and QUANTUM_LIB_SRC for ARM(chibios) * remove ARFLAGS * tmk_core/arm_atsam.mk:AR: remove 'rcs'
* fix LIB_SRC and QUANTUM_LIB_SRC for ARM(chibios) * remove ARFLAGS * tmk_core/arm_atsam.mk:AR: remove 'rcs'
* fix LIB_SRC and QUANTUM_LIB_SRC for ARM(chibios) * remove ARFLAGS * tmk_core/arm_atsam.mk:AR: remove 'rcs'
Description
On ARM targets, the LIB_SRC and QUANTUM_LIB_SRC macros have been corrected as they do not function properly.
Types of Changes
Issues Fixed or Closed by This PR
Checklist