E6V2 LE HHKB love #4079
E6V2 LE HHKB love #4079
Conversation
johu
commented
Oct 5, 2018
johu
commented
- HHKB layout support
- my layout
|
@noroadsleft This look good to you? |
| $ make e6v2/le:johu:dfu | ||
| ``` | ||
|
|
||
| See [build environment setup] then the [make instructions] for more information. |
There was a problem hiding this comment.
Please change this line to:
See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
and then delete Lines 35 and 36.
There was a problem hiding this comment.
I will add the the last sentence, but I prefer the links at the bottom as the markdown is way more readable in source.
There was a problem hiding this comment.
This information should also be in the keyboard's readme, not just in a keymap readme.
There was a problem hiding this comment.
This information should also be in the keyboard's readme, not just in a keymap readme.
Done
johu
force-pushed
the
e6v2
branch
2 times, most recently
from
8ad99cf to
cfe3a70
Compare
|
Awesome! |
|
Squashing those commits was not good imho, as they are logical separated. |
|
You're right. Sorry. Though, generally, this should have been two separate PRs, one for the keyboard, and one for the keymap. This is "my bad". If you would like, we can revert it and then re-submit it, but it should be okay as is. |
|
https://docs.qmk.fm/#/contributing?id=keymaps So, definitely my fault. WIll try to do better in the future. |
* 'master' of git://github.com/qmk/qmk_firmware: (302 commits) Keymap: Added Planck keymap: jcorrado (qmk#4083) Keyboard: Helix five_rows keymap reduced size (qmk#4082) E6V2 LE HHKB love (qmk#4079) Keymap: Add french iso layout for dz60 (thomasviaud) (qmk#4080) ARM SWD guide Keyboard: set SAFE_RANGE (qmk#4078) Keyboard: DZ60: add Plate B layouts (qmk#4076) rgb_matrix: continue calling rgb_matrix_indicators() when toggled off Keymap: Added personal userspace and keymaps. (qmk#4073) Add mousekey_send to (un)register_code rn42 compilation error fix (qmk#4050) process_ucis: Add a callback for success (qmk#4067) Keyboard: add info.json for qmk configurator (qmk#4063) Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052) Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058) Keyboard: Add handwired/pteron config and keymaps (qmk#4060) Keyboard: Added split backspace layout for the b.mini (qmk#4051) Keyboard: Add namecard keyboard (qmk#4044) handwired/ibm122m: refactor and Configurator support (qmk#4054) Keyboard: Added JN68M keyboard to handwired (qmk#4053) ...
* Keyboard: E6V2 LE HHKB layout support * Keymap: Add johu's E6V2 LE HHKB layout
* Keyboard: E6V2 LE HHKB layout support * Keymap: Add johu's E6V2 LE HHKB layout
* Keyboard: E6V2 LE HHKB layout support * Keymap: Add johu's E6V2 LE HHKB layout
