Added dactyl-manuform 4x6 and keymap. #4058
Conversation
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #ifndef CONFIG_USER_H |
There was a problem hiding this comment.
If you could replace the include guard (the ifndef, define, and endif at the end) with just #pragma once?
It's simpler, and less prone to user error, so if you could make this switch?
| #ifndef CONFIG_USER_H | ||
| #define CONFIG_USER_H | ||
|
|
||
| #include "../../config.h" |
There was a problem hiding this comment.
This line is not actually needed, and should be removed.
Specifically, the build script automatically includes all of the config.h files, so this is not necessary.
| @@ -0,0 +1,89 @@ | |||
| #include "dactyl_manuform.h" | |||
There was a problem hiding this comment.
Could you replace this include with #include QMK_KEYBOARD_H instead?
| @@ -0,0 +1,89 @@ | |||
| #include "dactyl_manuform.h" | |||
| #include "action_layer.h" | |||
There was a problem hiding this comment.
Could you remove all of these includes?
They get included automatically, at various points in the built process, so they are redundant and not necessary here.
| }; | ||
|
|
||
|
|
||
| void persistent_default_layer_set(uint16_t default_layer) { |
There was a problem hiding this comment.
This function isn't needed, and has been deprecated in favor of set_single_persistent_default_layer
There was a problem hiding this comment.
Do you mean I can remove the whole function from the file (delete line 83-86)?
| @@ -0,0 +1,3 @@ | |||
| ifndef QUANTUM_DIR | |||
There was a problem hiding this comment.
Could you remove this (ifndef/include/endif) block?
It's not needed, and is a holdover from the old build system.
And actually, could you probably safely remove the entire file, as it's not being used.
| @@ -8,6 +8,8 @@ | |||
| #include "4x5.h" | |||
| #elif KEYBOARD_handwired_dactyl_manuform_5x7 | |||
| #include "5x7.h" | |||
| #elif KEYBOARD_handwired_dactyl_manuform_4x6 | |||
There was a problem hiding this comment.
Could you put this above the 5x7? Namely, this is OCD, but ....
|
I've added all changes you recommended. Again, thanks for all the hard work by you and all other maintainers! |
|
Well, thank you! |
* 'master' of https://github.com/qmk/qmk_firmware: (69 commits) rgb_matrix: continue calling rgb_matrix_indicators() when toggled off Keymap: Added personal userspace and keymaps. (qmk#4073) Add mousekey_send to (un)register_code rn42 compilation error fix (qmk#4050) process_ucis: Add a callback for success (qmk#4067) Keyboard: add info.json for qmk configurator (qmk#4063) Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052) Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058) Keyboard: Add handwired/pteron config and keymaps (qmk#4060) Keyboard: Added split backspace layout for the b.mini (qmk#4051) Keyboard: Add namecard keyboard (qmk#4044) handwired/ibm122m: refactor and Configurator support (qmk#4054) Keyboard: Added JN68M keyboard to handwired (qmk#4053) Keymap: Add RGB matrix keypress effects and reduce firmware size. (qmk#4055) Keyboard: KBD4x: corrected info.json file (qmk#4056) Keyboard: Mint60: Configurator support and readme cleanup (qmk#4057) Add missing F-keys to ergodox_infinity input_club Enable support for Linux Mint 18 with linux_install.sh (qmk#4042) add JP keycode for MacOSX (qmk#4033) New keyboard: Baguette (qmk#4047) ...
* 'master' of git://github.com/qmk/qmk_firmware: (302 commits) Keymap: Added Planck keymap: jcorrado (qmk#4083) Keyboard: Helix five_rows keymap reduced size (qmk#4082) E6V2 LE HHKB love (qmk#4079) Keymap: Add french iso layout for dz60 (thomasviaud) (qmk#4080) ARM SWD guide Keyboard: set SAFE_RANGE (qmk#4078) Keyboard: DZ60: add Plate B layouts (qmk#4076) rgb_matrix: continue calling rgb_matrix_indicators() when toggled off Keymap: Added personal userspace and keymaps. (qmk#4073) Add mousekey_send to (un)register_code rn42 compilation error fix (qmk#4050) process_ucis: Add a callback for success (qmk#4067) Keyboard: add info.json for qmk configurator (qmk#4063) Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052) Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058) Keyboard: Add handwired/pteron config and keymaps (qmk#4060) Keyboard: Added split backspace layout for the b.mini (qmk#4051) Keyboard: Add namecard keyboard (qmk#4044) handwired/ibm122m: refactor and Configurator support (qmk#4054) Keyboard: Added JN68M keyboard to handwired (qmk#4053) ...
* Added dactyl-manuform 4x6 and keymap. * Did changes recommended by drashna.
* Added dactyl-manuform 4x6 and keymap. * Did changes recommended by drashna.
* Added dactyl-manuform 4x6 and keymap. * Did changes recommended by drashna.
I've added config and keymap for my preferred Dactyl-ManuForm layout, 4x6.
I mainly just took the 5x6 stuff and removed a row from the layout and the keymap.