Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handwired/pteron config and keymaps #4060

Merged
merged 8 commits into from
Oct 3, 2018
Merged

Conversation

FSund
Copy link
Contributor

@FSund FSund commented Oct 3, 2018

I would like to add my handwired keyboard "pteron" to the QMK keyboards.

Some background information on the keyboard can be found in the github repo where the case files are hosted, and in the accompanying Keebtalk thread.

I have only made a config for the default 56key layout for now, but it should be easy to adapt to the smaller versions.

@@ -0,0 +1,37 @@
#ifndef CONFIG_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could replace the include guard (the ifndef, define, and endif at the end) with just #pragma once?

It's simpler, and less prone to user error, so if you could make this switch?

#define VENDOR_ID 0xFEED
#define PRODUCT_ID 0x6060
#define DEVICE_VER 0x0001
// #define MANUFACTURER qmkbuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be there.
If you want "QMK Community" is a good option for this.

@@ -0,0 +1,119 @@
#include "pteron.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this include with #include QMK_KEYBOARD_H instead?

And the action_layer include is not needed, and should be removed.

@@ -0,0 +1,105 @@
#include "pteron.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this include with #include QMK_KEYBOARD_H instead?

And the action_layer include is not needed, and should be removed.


make handwired/pteron:default

See [build environment setup](https://docs.qmk.fm/build_environment_setup.html) then the [make instructions](https://docs.qmk.fm/make_instructions.html) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this link block with this, instead:

See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).

# Build Options
# comment out to disable the options.
#
BOOTMAGIC_ENABLE ?= no # Virtual DIP switch configuration(+1000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove all of the question marks here? They're not needed.

@FSund
Copy link
Contributor Author

FSund commented Oct 3, 2018

I've done all the changes you mentioned (and replaced an include guard you missed). Could you have a look at it?

Thanks a lot for all your work with the QMK repo!

@drashna
Copy link
Member

drashna commented Oct 3, 2018

Awesome, thanks!

@drashna drashna merged commit f01133d into qmk:master Oct 3, 2018
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Oct 5, 2018
* 'master' of https://github.com/qmk/qmk_firmware: (69 commits)
  rgb_matrix: continue calling rgb_matrix_indicators() when toggled off
  Keymap: Added personal userspace and keymaps. (qmk#4073)
  Add mousekey_send to (un)register_code
  rn42 compilation error fix (qmk#4050)
  process_ucis: Add a callback for success (qmk#4067)
  Keyboard: add info.json for qmk configurator (qmk#4063)
  Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052)
  Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058)
  Keyboard: Add handwired/pteron config and keymaps (qmk#4060)
  Keyboard: Added split backspace layout for the b.mini (qmk#4051)
  Keyboard: Add namecard keyboard (qmk#4044)
  handwired/ibm122m: refactor and Configurator support (qmk#4054)
  Keyboard: Added JN68M keyboard to handwired (qmk#4053)
  Keymap: Add RGB matrix keypress effects and reduce firmware size. (qmk#4055)
  Keyboard: KBD4x: corrected info.json file (qmk#4056)
  Keyboard: Mint60: Configurator support and readme cleanup (qmk#4057)
  Add missing F-keys to ergodox_infinity input_club
  Enable support for Linux Mint 18 with linux_install.sh (qmk#4042)
  add JP keycode for MacOSX (qmk#4033)
  New keyboard: Baguette (qmk#4047)
  ...
akatrevorjay added a commit to akatrevorjay/qmk_firmware that referenced this pull request Oct 8, 2018
* 'master' of git://github.com/qmk/qmk_firmware: (302 commits)
  Keymap: Added Planck keymap: jcorrado (qmk#4083)
  Keyboard: Helix five_rows keymap reduced size (qmk#4082)
  E6V2 LE HHKB love (qmk#4079)
  Keymap: Add french iso layout for dz60 (thomasviaud) (qmk#4080)
  ARM SWD guide
  Keyboard: set SAFE_RANGE (qmk#4078)
  Keyboard: DZ60: add Plate B layouts (qmk#4076)
  rgb_matrix: continue calling rgb_matrix_indicators() when toggled off
  Keymap: Added personal userspace and keymaps. (qmk#4073)
  Add mousekey_send to (un)register_code
  rn42 compilation error fix (qmk#4050)
  process_ucis: Add a callback for success (qmk#4067)
  Keyboard: add info.json for qmk configurator (qmk#4063)
  Keyboard: Adding Split Space support for Mechmini 1 (qmk#4052)
  Keyboard: Added dactyl-manuform 4x6 and keymap. (qmk#4058)
  Keyboard: Add handwired/pteron config and keymaps (qmk#4060)
  Keyboard: Added split backspace layout for the b.mini (qmk#4051)
  Keyboard: Add namecard keyboard (qmk#4044)
  handwired/ibm122m: refactor and Configurator support (qmk#4054)
  Keyboard: Added JN68M keyboard to handwired (qmk#4053)
  ...
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Oct 13, 2018
* Added pteron files made via from kbfirmware.com.

* Added readme.

* Made some progress on Pteron keymap.

* More keymap.

* Updated bootloader, added some keymap illustrations.

* Moved default keymap to FSund, made default keymap from default preonic keymap.

* Fixed typo in default pteron keymap.

* Made changes recommended by drashna.
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Added pteron files made via from kbfirmware.com.

* Added readme.

* Made some progress on Pteron keymap.

* More keymap.

* Updated bootloader, added some keymap illustrations.

* Moved default keymap to FSund, made default keymap from default preonic keymap.

* Fixed typo in default pteron keymap.

* Made changes recommended by drashna.
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
* Added pteron files made via from kbfirmware.com.

* Added readme.

* Made some progress on Pteron keymap.

* More keymap.

* Updated bootloader, added some keymap illustrations.

* Moved default keymap to FSund, made default keymap from default preonic keymap.

* Fixed typo in default pteron keymap.

* Made changes recommended by drashna.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants