Keyboard: Add support for bpiphany's HID Liberation Device #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jul 23, 2018
keyboards/hid_liber/hid_liber.h
Outdated
| * |Ctl|Gui|Alt| Space |Alt|Gui|App|Ctl| |Lef|Dow|Rig| | ||
| * `-----------------------------------------------------------' `-----------' | ||
| */ | ||
| #define KEYMAP( \ |
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #ifndef CONFIG_USER_H |
There was a problem hiding this comment.
Could you change the boilerplate here to #pragma once.
Eg, the file should look like:
#pragma once
#define PERMISSIVE_HOLD| #define _FL 2 // Function Layer | ||
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
| [_BL] = KEYMAP( \ |
There was a problem hiding this comment.
Change All of the KEYMAPs to LAYOUT
| RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight. Do not enable this with audio at the same time. | ||
| SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | ||
|
|
||
| ifndef QUANTUM_DIR |
There was a problem hiding this comment.
Could you remove this block?
It's not needed and a hold over from the old makefile system.
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #ifndef CONFIG_USER_H |
There was a problem hiding this comment.
Could you replace this and the rest of the contents with just #pragma once?
| #define _FL 1 // Media Layer | ||
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
| [_BL] = KEYMAP( \ |
There was a problem hiding this comment.
Change all of the KEYMAPs to LAYOUT.
| RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight. Do not enable this with audio at the same time. | ||
| SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | ||
|
|
||
| ifndef QUANTUM_DIR |
There was a problem hiding this comment.
Could you remove this block?
It's a holdover from the old makefile system.
| /* Specifies the ports and pin numbers for the columns */ | ||
| static | ||
| const uint8_t col_bit[MATRIX_COLS] = { 0x00, 0x02, 0x04, 0x06, 0x08, 0x0A, 0x0C, 0x0E}; | ||
|
|
There was a problem hiding this comment.
Please add this here:
__attribute__ ((weak))
void matrix_init_kb(void) {
matrix_init_user();
}
__attribute__ ((weak))
void matrix_scan_kb(void) {
matrix_scan_user();
}
__attribute__ ((weak))
void matrix_init_user(void) {
}
__attribute__ ((weak))
void matrix_scan_user(void) {
}Otherwise, this can/will cause compile issues in some cases.
|
I believe that should be all of the requested changes. |
drashna
approved these changes
Jul 31, 2018
|
Awesome, thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
* Keyboard: Added support for HID Liberation Device * Keymap: Custom (bakageta) layout for HID Liberation Device * Updated with requested changes
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Keyboard: Added support for HID Liberation Device * Keymap: Custom (bakageta) layout for HID Liberation Device * Updated with requested changes
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Keyboard: Added support for HID Liberation Device * Keymap: Custom (bakageta) layout for HID Liberation Device * Updated with requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the HID Liberation Device, a replacement controller for Filco Majestouch TLK keyboards. Added a default ANSI keymap as well as a lightly customized layout.