Assume only 32u4 boards can run 'promicro' converters #23312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Mar 19, 2024
tzarc
approved these changes
Mar 20, 2024
|
Should this go to |
14 tasks
zvecr
force-pushed
the
converter_promicro_only_32u4
branch
from
55c6b8f to
6596271
Compare
dlip
added a commit
to dlip/qmk_firmware
that referenced
this pull request
Mar 21, 2024
* upstream/master: (40 commits) [Keyboard] Add marshkeys flowerpad (qmk#23240) Add TechnicPad macropad (qmk#23238) Add handwired/Jotlily60 (qmk#23212) Add the EQUATOR keyboard (qmk#23237) Support for slice65 from PizzaKeyboards (qmk#23148) Add Swiss support (qmk#23272) Assume only 32u4 boards can run 'promicro' converters (qmk#23312) Add Macropad 6Pad (qmk#23099) Fix invalid use of stemcell converter (qmk#23317) Updates to PR Checklist (qmk#23318) [Keyboard] Add posey_split v4/v5 (qmk#23258) Added WT65-H3 (HIBI HIBIKI) (qmk#22886) Added WT65-G3 (HIBI HIBIKI) (qmk#22888) Modify wording in 'getting_started_introduction.md' (qmk#23232) Bump tj-actions/changed-files from 42 to 43 (qmk#23282) AMJKeyboard AMJ96 Layout Additions (qmk#23267) Fixup cipulot eeprom. (qmk#23280) Update feature_tri_layer.md - typo (qmk#23275) [Keyboard] add glyphkbd_v2 (qmk#23131) Add support new kb_elmo PCBs (qmk#23138) ...
mzyt
pushed a commit
to mzyt/qmk_firmware
that referenced
this pull request
May 6, 2024
girtsf
pushed a commit
to girtsf/qmk_firmware
that referenced
this pull request
Jun 5, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users should not be trying to target "blackpill" based boards with the current available converters.
The following is logically incorrect...
However the error should be a bit more human readable than what is produced.
Long term, #20330 will solve the issue but that involves many keyboard upates.
Types of Changes
Issues Fixed or Closed by This PR
Checklist