Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove converter assumption that everything is a promicro #20330

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 3, 2023

Description

Reduce the scenarios down to "valid" conversion targets. In the future, this will also allow configurator to only display converter drop-downs when applicable.

For example, the following will now correctly fail:

make xiudi/xd84:default CONVERT_TO=kb2040

Alternative could be to add just "pin_compatible": "promicro"? Ive scripted the changes so would be easy to adapt either way.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the converter_no_default branch from c89c560 to 9e8ba79 Compare May 4, 2023 14:59
@dunk2k dunk2k mentioned this pull request Jun 14, 2023
14 tasks
@qmk qmk deleted a comment from dunk2k Jun 14, 2023
@qmk qmk deleted a comment from dunk2k Jun 14, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 14, 2023
@tzarc tzarc removed the stale Issues or pull requests that have become inactive without resolution. label Dec 8, 2023
@zvecr zvecr marked this pull request as draft March 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants