Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct elite_c converter #21242

Closed
wants to merge 4 commits into from
Closed

Correct elite_c converter #21242

wants to merge 4 commits into from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jun 14, 2023

Description

Relates to #20330

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
Copy link
Contributor Author

dunk2k commented Jun 14, 2023 •
edited
Loading

@qmk/collaborators:
Is it safe to assume that all keyboards with
"processor": "atmega32u4" and "bootloader": "atmel-dfu" are an Elite-C micro controller unit?

@lesshonor
Copy link
Contributor

@qmk/collaborators: Is it safe to assume that all keyboards with "processor": "atmega32u4" and "bootloader": "atmel-dfu" are an Elite-C micro controller unit?

Absolutely not.

@waffle87
Copy link
Member

Probably something like 10% of keyboards with atmel-dfu/atmega32u4 settings use an Elite-C. I suggest you carefully confirm each of the keyboards you're changing are meant to be built with an Elite-C, and are not using an integrated microcontroller.

@dunk2k
Copy link
Contributor Author

dunk2k commented Jun 14, 2023

Probably something like 10% of keyboards with atmel-dfu/atmega32u4 settings use an Elite-C. I suggest you carefully confirm each of the keyboards you're changing are meant to be built with an Elite-C, and are not using an integrated microcontroller.

I've been using keyboard's respective readme(s) as a means to differentiate between integrated and Elite-C.

@lesshonor
Copy link
Contributor

lesshonor commented Jun 14, 2023 •
edited
Loading

I've been using keyboard's respective readme(s) as a means to differentiate between integrated and Elite-C.

If something says it is "compatible with a Pro Micro or an Elite-C", as the Labyrinth75 does, you need to set "development_board": "promicro".

Not every Pro Micro-format board has the Elite-C's additional pins even if it doesn't use caterina as a bootloader—ex: the Bit-C, the melmicro, the ShiroMicro, or even a standard Pro Micro that somebody's just ISP flashed.

@dunk2k dunk2k marked this pull request as ready for review June 14, 2023 21:34
@zvecr
Copy link
Member

zvecr commented Jun 14, 2023

Correct elite_c converter

None of this actually "corrects" the converters.

The changes to data/mappings/defaults.hjson along with the keyboard changes are not something I would want to accept at the moment, as it will break valid conversions where the board isnt actually using the extra elite c pins.

Closing as the rest of the changes are something that is already being handled elsewhere.

@zvecr zvecr closed this Jun 14, 2023
lesshonor
lesshonor reviewed Jun 14, 2023
View reviewed changes
keyboards/abacus/info.json
@@ -21,8 +21,7 @@
"ws2812": {
"pin": "D1"
},
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"development_board": "elite_c",

This comment was marked as outdated.

Sign in to view

keyboards/alt34/rev1/info.json
@@ -13,8 +13,7 @@
"rows": ["D7", "E6", "B4", "B5"]
},
"diode_direction": "COL2ROW",
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"development_board": "elite_c",

This comment was marked as outdated.

Sign in to view

keyboards/clawsome/bookerboard/info.json
@@ -13,8 +13,7 @@
"rows": ["B5", "B4", "E6", "D7"]
},
"diode_direction": "COL2ROW",
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"development_board": "elite_c",

This comment was marked as outdated.

Sign in to view

keyboards/clawsome/sidekick/info.json
@@ -13,8 +13,7 @@
"rows": ["D0", "C6", "B2", "B6", "B5"]
},
"diode_direction": "COL2ROW",
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"development_board": "elite_c",

This comment was marked as outdated.

Sign in to view

keyboards/crkbd/r2g/info.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes. This uses an integrated MCU.

keyboards/delikeeb/vanana/info.json
@@ -6,6 +6,5 @@
"vid": "0x9906",
"pid": "0x0013"
},
"processor": "atmega32u4",
"bootloader": "atmel-dfu"
"development_board": "elite_c"

This comment was marked as outdated.

Sign in to view

keyboards/chalice/info.json
@@ -16,8 +16,7 @@
"rows": ["F4", "D1", "D0", "F5", "D4", "F6", "B4", "B5", "B2", "B6"]
},
"diode_direction": "COL2ROW",
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"development_board": "elite_c",

This comment was marked as outdated.

Sign in to view

@dunk2k dunk2k deleted the convert_elitec branch June 14, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor left review comments

@waffle87 waffle87 waffle87 left review comments

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunk2k @lesshonor @waffle87 @zvecr