Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TechnicPad macropad #23238

Merged
merged 23 commits into from
Mar 21, 2024
Merged

Add TechnicPad macropad #23238

merged 23 commits into from
Mar 21, 2024

Conversation

nwhirschfeld
Copy link
Contributor

Description

Added TechnicPad keyboard (macropad) and the keymaps default and via.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 7, 2024
@nwhirschfeld nwhirschfeld changed the title Added TechnicPad keyboard (macropad) and the keymaps _default_ and _via_. Add TechnicPad keyboard (macropad) and the keymaps _default_ and _via_. Mar 7, 2024
zvecr
zvecr requested changes Mar 8, 2024
View reviewed changes
keyboards/technicpad/rules.mk Outdated Show resolved Hide resolved
keyboards/technicpad/readme.md Outdated Show resolved Hide resolved
keyboards/technicpad/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/technicpad/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/technicpad/keymaps/via/keymap.json Outdated Show resolved Hide resolved
keyboards/technicpad/info.json Outdated Show resolved Hide resolved
keyboards/technicpad/readme.md Outdated Show resolved Hide resolved
keyboards/technicpad/info.json Outdated Show resolved Hide resolved
@zvecr zvecr changed the title Add TechnicPad keyboard (macropad) and the keymaps _default_ and _via_. Add TechnicPad macropad Mar 8, 2024
nwhirschfeld and others added 9 commits March 9, 2024 12:01
@nwhirschfeld
resolved advice: https://github.com/qmk/qmk_firmware/pull/23238\#disc…
f4a9bf3 
…ussion_r1517076010
@nwhirschfeld
resolved advice: https://github.com/qmk/qmk_firmware/pull/23238\#disc…
7cba09e 
…ussion_r1517077273
@nwhirschfeld @zvecr
Update keyboards/technicpad/keymaps/via/keymap.json
9c221bb 
Co-authored-by: Joel Challis <[email protected]>
@nwhirschfeld @zvecr
Update keyboards/technicpad/readme.md
cfe6f6d 
Co-authored-by: Joel Challis <[email protected]>
@nwhirschfeld @zvecr
Update keyboards/technicpad/info.json
afeb96c 
Co-authored-by: Joel Challis <[email protected]>
@nwhirschfeld @zvecr
Update keyboards/technicpad/rules.mk
57c7717 
Co-authored-by: Joel Challis <[email protected]>
@nwhirschfeld
resolved advice: https://github.com/qmk/qmk_firmware/pull/23238\#disc…
b12a2cd 
…ussion_r1517075772 moved keyboard to handwired
@nwhirschfeld
resolved advice: https://github.com/qmk/qmk_firmware/pull/23238\#disc…
c999cb2 
…ussion_r1517076126 removed keymaps/via/rules.mk
@nwhirschfeld
Merge branch 'master' into technicpad
19b6562
@nwhirschfeld
Copy link
Contributor Author

@zvecr Thanks a lot for your review!

@nwhirschfeld nwhirschfeld requested a review from zvecr March 9, 2024 12:05
zvecr
zvecr requested changes Mar 10, 2024
View reviewed changes
keyboards/handwired/technicpad/info.json Outdated Show resolved Hide resolved
keyboards/handwired/technicpad/info.json Outdated Show resolved Hide resolved
keyboards/handwired/technicpad/info.json Outdated Show resolved Hide resolved
@nwhirschfeld nwhirschfeld requested a review from zvecr March 10, 2024 17:29
@drashna drashna requested a review from a team March 15, 2024 02:03
@zvecr zvecr merged commit 5d6b291 into qmk:master Mar 21, 2024
3 checks passed
@nwhirschfeld nwhirschfeld deleted the technicpad branch March 21, 2024 06:21
dlip added a commit to dlip/qmk_firmware that referenced this pull request Mar 21, 2024
@dlip
Merge remote-tracking branch 'upstream/master' into dlip
6077434 
* upstream/master: (40 commits)
  [Keyboard] Add marshkeys flowerpad (qmk#23240)
  Add TechnicPad macropad (qmk#23238)
  Add handwired/Jotlily60 (qmk#23212)
  Add the EQUATOR keyboard (qmk#23237)
  Support for slice65 from PizzaKeyboards (qmk#23148)
  Add Swiss support (qmk#23272)
  Assume only 32u4 boards can run 'promicro' converters (qmk#23312)
  Add Macropad 6Pad (qmk#23099)
  Fix invalid use of stemcell converter (qmk#23317)
  Updates to PR Checklist (qmk#23318)
  [Keyboard] Add posey_split v4/v5 (qmk#23258)
  Added WT65-H3 (HIBI HIBIKI) (qmk#22886)
  Added WT65-G3 (HIBI HIBIKI) (qmk#22888)
  Modify wording in 'getting_started_introduction.md' (qmk#23232)
  Bump tj-actions/changed-files from 42 to 43 (qmk#23282)
  AMJKeyboard AMJ96 Layout Additions (qmk#23267)
  Fixup cipulot eeprom. (qmk#23280)
  Update feature_tri_layer.md - typo (qmk#23275)
  [Keyboard] add glyphkbd_v2 (qmk#23131)
  Add support new kb_elmo PCBs (qmk#23138)
  ...
@nwhirschfeld nwhirschfeld mentioned this pull request Mar 21, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@nwhirschfeld
Add TechnicPad macropad (qmk#23238)
bb08ff8
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@nwhirschfeld @girtsf
Add TechnicPad macropad (qmk#23238)
9fa22e5
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@nwhirschfeld @whoisjordangarcia
Add TechnicPad macropad (qmk#23238)
d7ecc3f
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@nwhirschfeld @nuess0r
Add TechnicPad macropad (qmk#23238)
2575299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nwhirschfeld @drashna @fauxpark @zvecr