-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backlight breathing overhaul #2187
Conversation
Currently having trouble with the meira board by @colemarkham. He seems to have a pretty unusual setup for backlight and breathing. For example, in rules.mk, he has I hope he can look over this and either bring his files more in line with other keyboards or tell me how his implementation is supposed to work. |
@@ -127,7 +127,7 @@ https://github.com/tekezo/Karabiner/issues/403 | |||
|
|||
## Esc and <code>`</code> on a Single Key | |||
|
|||
See the [Grave Escape](feature_grave_escape.md) feature. | |||
See the [Grave Escape](feature_grave_esc.md) feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has nothing to do with the rest but I put in the fix anyway,
These things should also fix the issues described here: #1415 |
… to reach true max brightness
This is awesome :) thanks! |
* add breathing to bananasplit * backlight breathing overhaul * fix the backlight_tick thing. * fix for vision_division backlight * fix a few keymaps and probably break breathing for some weirdly set-up boards. * remove BL_x keycodes because they made unreasonable assumptions * some fixes for BL keycodes * integer cie lightness scaling * use cie lightness for non-breathing backlight and make breathing able to reach true max brightness
* add breathing to bananasplit * backlight breathing overhaul * fix the backlight_tick thing. * fix for vision_division backlight * fix a few keymaps and probably break breathing for some weirdly set-up boards. * remove BL_x keycodes because they made unreasonable assumptions * some fixes for BL keycodes * integer cie lightness scaling * use cie lightness for non-breathing backlight and make breathing able to reach true max brightness
This is a refactor of the breathing code that also fixes #2181.