-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ergodox Infinity backlight doesn't work reliably #1415
Comments
Toggle, inc, and dec all seem to work correctly for me. |
It happens when I press any of the BL_ buttons. I am going to try and reinstall the keymaps when I get home tonight. |
That is a video showing how my keyboard behaves. The BL_TOGG seems to be the only button that behaves as it should. BL_ON and BL_OFF seem to be doing the same thing. And the right hand doesn't light up at all. |
For the right half, are you sure that you have flashed it separately with the correct code?
void backlight_level(uint8_t level)
{
backlight_config.level ^= level;
backlight_config.enable = !!backlight_config.level;
eeconfig_update_backlight(backlight_config.raw);
backlight_set(backlight_config.level);
} The function also doesn't make sure that the backlight level is within the correct range. I will fix this within the next few days. |
My build command is: make ergodox-infinity-doxxy VISUALIZER_ENABLE=yes LCD_BACKLIGHT_ENABLE=yes LCD_ENABLE=yes BACKLIGHT_ENABLE=yes MASTER=left and of course MASTER=right for the right hand file. |
But did you connect the right hand to the computer alone and flash it? Both halves need to be flashed separately. |
Yes that is what I did. I unplug whichever hand is not being flashed. I connect the hands into the computer via USB hub in my monitor. |
I have tried adding "BL_" commands on both hands but still only the left hand works. |
Does anyone else experience this? Any additional information or help with debugging this issue is would greatly be appreciated. I found an uninitialized variable related to the backlight LEDs. I don't think it can explain all the issues here, but I will send a fix for it quite soon. |
I opened a pull request #1475, which fixes the unititialized variable, could you please check if that fixes the problem? |
I can do video to document, but I have not done so yet due to the simpler behavior versus what I reported in gitter and corrected. My current keymap is in a branch at https://github.com/r2d2rogers/qmk_firmware/blob/r2d2rogers/keyboards/ergodox/keymaps/r2d2rogers/keymap.c |
I'm seeing similar behavior to what @packman86 described. Only the left side will light up (I've only tried |
Good timing, we just found an issue with @r2d2rogers. I will try to send a pull request tomorrow, but I'm not entirely sure it's the same issue. |
@fredizzimo well I can at least test the PR. 😊 |
The pull request has now been submtted. #1776 |
@jackhumbert PR got merged, resolved? |
Yeap! Thank :) |
Continuing the discussion from #1361.
By @packman86
My Response
And another response from @packman86
Here's my response to that:
That sounds very odd. Does the glitches only happen when you change change the backlight, or does it happens sometimes, when you just leave the backlight on for an extended period of time?
Does anyone else experience similar issues?
The text was updated successfully, but these errors were encountered: