Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NO_BACKLIGHT_CLOCK #6418

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 26, 2019

The code that used this define was refactored a loooong time ago (#2187), and so it does absolutely nothing now.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually see where that definition got removed in the referenced PR, but:

👍

@fauxpark
Copy link
Member Author

fauxpark commented Jul 26, 2019

That's weird, it's present here: 4931510#diff-7cc280270d4afece33b8b15ed53abebb

Basically, the define was replaced with NO_HARDWARE_PWM, but you should never need to define that in the keyboard space as the big block that defines all the PWM registers etc. will determine whether or not hardware PWM can be used (and even more so after #6202 😉).

@noroadsleft
Copy link
Member

Must've been a GitHub glitch or something; I scrolled through the diff twice and didn't find it either time.

@zvecr zvecr merged commit 0bd0315 into qmk:master Jul 27, 2019
@fauxpark fauxpark deleted the remove-no-backlight-clock branch July 27, 2019 02:51
raymond-w-ko pushed a commit to raymond-w-ko/qmk_firmware that referenced this pull request Aug 4, 2019
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants