Add GMMK Numpad (Default, Via) #20067

RustedAperture · 2023-03-08T20:29:30Z

Description

Adding the main framework needed to get QMK running along with Via and Vial. Most credit goes to @GloriousThrall.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tzarc · 2023-03-08T21:41:46Z

I've gone ahead and unmarked the "I've read the PR Checklist" as some things have been ignored.
Feel free to rectify the issues outlined in the document and let us know when you're done.

RustedAperture · 2023-03-09T02:09:00Z

@tzarc I believe I've fixed the issues... I've removed Vial, added a readme, and moved the needed settings into info.json.
I've also removed duplicate and unneeded definitions in the config.h
If I'm missing anything please let me know

keyboards/gmmk/numpad/config.h

keyboards/gmmk/numpad/keymaps/via/config.h

keyboards/gmmk/numpad/numpad.h

RustedAperture · 2023-03-09T18:41:09Z

@adophoxia thank you for the guidance. I was basing my branch on the GMMK pro which still had the older header file containing the matrix. The above changes have been made.

keyboards/gmmk/numpad/info.json

keyboards/gmmk/numpad/keymaps/default/keymap.c

keyboards/gmmk/numpad/numpad.h

adophoxia

LGTM! Better to remove the reference to Vial in the PR title. :)

RustedAperture · 2023-03-09T19:12:41Z

LGTM! Better to remove the reference to Vial in the PR title. :)

Removed, forgot I had it in there as I'm also working on vial at the same time. Thanks for the help!

keyboards/gmmk/numpad/config.h

keyboards/gmmk/numpad/keymaps/default/keymap.c

keyboards/gmmk/numpad/keymaps/via/keymap.c

keyboards/gmmk/numpad/numpad.c

keyboards/gmmk/numpad/numpad.h

keyboards/gmmk/numpad/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

RustedAperture · 2023-03-20T20:14:12Z

Let me know if anything needs to be changed. Currently using this build daily without issues now.

keyboards/gmmk/numpad/info.json

keyboards/gmmk/numpad/config.h

keyboards/gmmk/numpad/keymaps/default/keymap.c

keyboards/gmmk/numpad/keymaps/via/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

keyboards/gmmk/numpad/config.h

keyboards/gmmk/numpad/matrix.c

Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>

* [Bug] Fix compiliation issue for Key Overrides (qmk#19856) * Elaborate on keyboard level encoder functionality (qmk#19839) * Fix regen script for macOS (qmk#19857) * [Keyboard] Add Quarkeys Z40 keyboard (qmk#19741) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * Remove unused RGBLight defines from config.h (qmk#19859) * Move Bootmagic config to data driven (qmk#19860) * Move LED indicator config to data driven (qmk#19800) * Clean up remaining rules.mk `MCU`/`BOOTLOADER`s (qmk#19778) Co-authored-by: Nick Brassel <[email protected]> * [Keyboard] Add Ciel65 (qmk#19847) Co-authored-by: Sắn <[email protected]> * Fixup durgod/dgk6x (scroll lock mis-defined as num lock) (qmk#19864) * Remove matrix size defines (qmk#19581) * Move `SOFT_SERIAL_PIN` to data driven (qmk#19863) * Fix API generation (qmk#19866) * Added via keymap for bpiphany/pegasushoof (qmk#19653) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> * Fixup for_science (qmk#19867) * Fix more build failures (qmk#19869) * Fixup pegasushoof VIA keymap (qmk#19874) * [Keyboard] Brick (qmk#19851) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Jason Chestnut <[email protected]> * [Keyboard] Add Degenpad (qmk#19812) Co-authored-by: jack <[email protected]> * Align sequencer keycodes (qmk#19875) * Add caps lock indicator capabilities to M75S (qmk#19552) * [Keyboard] Add LED startup sequence to Lumberjack (qmk#19841) * Add ac001 keyboard (qmk#19868) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]> * Add mouse layer to Kprepublic BM40HSRGB Coffee layout (qmk#19878) Co-authored-by: Fae <[email protected]> * Fix functions when `NO_ACTION_TAPPING` is defined (qmk#11528) * Add `mass-compile` ability to filter by key existence. (qmk#19885) * BM40 keymap for Skewwhiffy, revamp (qmk#19876) * [Keymap] Add encoder map to degenpad default keymap (qmk#19880) * Move layouts for direct_pins boards to data driven (qmk#19872) * Move `KC_MISSION_CONTROL`/`KC_LAUNCHPAD` keycodes to core (qmk#19884) * Add license headers to all default layout keymaps (qmk#19888) * Stub changelog * Fix date * Refactor more KC_MISSION_CONTROL/KC_LAUNCHPAD usages (qmk#19891) * New keymap for GMMK2 Compact (qmk#19430) Co-authored-by: Joel Challis <[email protected]> * Move backlight config to data driven, part 1 (qmk#19887) * Add some missing `#pragma once`s (qmk#19902) * Remove default and unused `BACKLIGHT_LEVELS` (qmk#19898) * Remove magic bodges from via keymaps (qmk#19890) * Fixup cannonkeys/satisfaction75 (readd `backlight.breathing_period`) (qmk#19901) * [Bug] Fix compilation error when defining QUICK_TAP_TERM_PER_KEY (qmk#19893) * Align magic keycodes (qmk#19877) * VIA Protocol 12 + fixes (qmk#19916) Co-authored-by: Wilba <[email protected]> Co-authored-by: zvecr <[email protected]> * Move QMK LUFA bootloader config to data driven (qmk#19879) * Migrate some more layouts to data driven (qmk#19889) * Reallocate SAFE_RANGE (qmk#19909) * Reallocate user/kb keycode ranges (qmk#19907) * Open Use standard magic keycodes in yandrstudio keymaps (qmk#19919) * Remove VIA specific use of `MACRO0*` (qmk#19918) * [Keyboard] Update Reviung Vendor ID (qmk#19928) * Move backlight config to data driven (qmk#19910) * Move encoder config to data driven (qmk#19923) Co-authored-by: Nick Brassel <[email protected]> * `keebio/kbo5000`: fix encoder config (qmk#19941) * Hide hex output when building uf2 (qmk#19940) * Breaking Changes 2023q1 changelog. (qmk#19945) * Add changelog for Leader Key refactor (qmk#19953) * Flag "builddefs" as core changes (qmk#19950) * [Keymap] Drashna updates for 0.20.0 (qmk#19960) * [Keyboard] remove non-existent method from ploopy documentation (qmk#19957) * Bump tj-actions/changed-files from 34 to 35 (qmk#19971) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 34 to 35. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v34...v35) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Keyboard] Add FRL84 PCB. (qmk#19942) Co-authored-by: jack <[email protected]> * [Keymap] sofle/keymaps/michal: rewrite (qmk#19938) * [Keyboard] Add GPAD8-2R (gpad8_2r) Macro Pad (qmk#19914) Co-authored-by: jack <[email protected]> * Disable safe.directory check (qmk#19970) * Remove `all` from list of animations in `info.json` (qmk#19978) * added Polly40 keyboard (qmk#19936) Co-authored-by: Ryan <[email protected]> Co-authored-by: jack <[email protected]> * [Keymap] Add davidrambo lulu keymap (qmk#19448) Co-authored-by: Joel Challis <[email protected]> * [Keyboard] Clean up contra & move to data-driven (qmk#19973) Co-authored-by: Joel Challis <[email protected]> * Check all keys have matrix positions when parsing C LAYOUT macros (qmk#19781) * Update branch names to reflect configurator's new deployment. (qmk#19999) * Initial deprecation policy documentation. (qmk#19908) * Add new keymap for Preonic rev3 (qmk#19706) * Add Support for Lilly58 r2g (qmk#19862) * Add support for lilly58 r2g by Mechboards * Add Keychron Q12 (qmk#19844) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * Unbreak switchplate/southpaw_65 after qmk#16277 (qmk#20015) Apparently the changes done in qmk#16277 swapped the values read from the PCA9555 expanders by mistake, which resulted in mixed up matrix columns. Fix the chip and register addresses to match the original code. * Reject VIA keys within info.json (qmk#20026) * keyboards/anavi: Add ANAVI Knobs 3 (qmk#18624) * [Keyboard] Add gummykey (qmk#19695) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> * [Docs] Discuss layout macro (qmk#19803) Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> * [Keyboard] Sejin EAT-1010R2 keyboard (qmk#19809) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> * Add disable git safe directory check step (qmk#20040) * [Keyboard] Add Karn Keyboard (qmk#19846) Co-authored-by: jack <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keymap] Smooted's BM80v2 keymap (qmk#19873) * implement rgb matrix for momokai keyboards (qmk#19904) Co-authored-by: jack <[email protected]> * VIA keymap for djinn (qmk#19881) * Fix processing of recently added system keycodes (qmk#20058) * [Keyboard] Teahouse Ayleen TKL (qmk#19900) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: CMM.Studio Freather <[email protected]> * EC Pro 2 PCB (qmk#19917) * EC Pro 2 firmware by Cipulot * [Docs] Add mod-tap section header (qmk#20041) * [Doc] Update PR checklist (qmk#19988) * Adding firmware for New Proto[Typist] in-stock PCBs. (qmk#19958) Co-authored-by: Less/Rikki <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Anjheos <[email protected]> * `qmk info`: add warning when layout is offset (qmk#20070) * Keebio/KBO-5000 Encoder Misconfiguration Fix for qmk#20073 (qmk#20074) * Add CI builds for default and via keymaps (qmk#20071) * [Keymap] Fix the secondary keyboard not updating WPM (qmk#20069) * [Keyboard] frobiac custom boards and layout (qmk#19883) * [Keymap] add crkbd/keymaps/markstos (qmk#19010) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * [Keyboard] update matrix pins for Polly40 (qmk#20002) * [Keyboard] Add tsubasa keyboard (qmk#19352) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: jack <[email protected]> * [Keyboard] Add Ortho48v2 Keyboard (qmk#18889) Co-authored-by: Drashna Jaelre <[email protected]> * Fix incorrect matrix positions for RGB LEDs (qmk#20082) * Move macro3 to data-driven (qmk#20046) * Zeno pcb V0.0.4 update via + fileformatting (qmk#20023) Co-authored-by: Drashna Jaelre <[email protected]> * Caerdroia Keyboard Firmware (qmk#20036) * [Keyboard] VIA support for Pierce keyboard (qmk#20045) * [Keyboard] Add Binpad BN009 R2 3x3 macropad (qmk#19992) Co-authored-by: Less/Rikki <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Add Spleeb default and custom firmware (qmk#19481) Co-authored-by: jack <[email protected]> * Yet another adventure in trying to fit things into a 32U4 (qmk#20091) * Teleport native bugfix (changed F411CC wear levelling) (qmk#20090) * workaround for flash size issue * enable mousekeys due to requests by some users * [Keyboard] Change pierce vendor ID (qmk#20088) * Ketch LGUI/LALT key transposed on Minivan layout (qmk#20025) * [Keyboard] Add k83 (qmk#19896) * Add Chimera65 Hotswap keyboard (qmk#20038) Co-authored-by: jack <[email protected]> * Allow for CI builds to run for 23 hours, instead of 6. (qmk#20094) * Allow for CI builds to run for 23 hours, instead of 6. (part deux) (qmk#20095) * [keyboard] Prevent LED flicker when connecting AnnePro 2 (qmk#19709) * Move Ferris Sweep to data-driven (qmk#20111) * Document Autocorrect callback functions (qmk#20115) * RF R1 8-9Xu PCB (qmk#20048) Co-authored-by: Tom Barnes <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * Update newbs_getting_started to include instructions for apple silicon (qmk#19579) Co-authored-by: Joel Challis <[email protected]> * [Keyboard] Add KP60 (qmk#20096) Co-authored-by: adophoxia <[email protected]> Co-authored-by: jack <[email protected]> * Let's use workflows to parallelise the builds. (qmk#20120) * Let's use workflows to parallelise the builds. * Nofail if files aren't present. * Formatting. * [Keyboard] New Keyboard - Sugar Glider (qmk#19933) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Less/Rikki <[email protected]> Co-authored-by: jack <[email protected]> * add new board: splaytoraid (qmk#20052) Co-authored-by: Less/Rikki <[email protected]> * [Keyboard] Add hineybush/h87_g2 (qmk#20053) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> * add tiger80 iso layout support (qmk#19975) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]> * [Keyboard] Add Atlantis PS17 (qmk#19952) * [Doc] Add example to keyboard housekeeping and some minor fixes (qmk#19968) Co-authored-by: jack <[email protected]> * Update keycodes_0.0.1_basic.hjson (qmk#20129) * Update keychron_common.c (qmk#20055) * [Keymap] Sugarglider VIA keymap enhancement (qmk#20140) * [Keyboard] Add Blueberry (qmk#19915) Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> * Add `qmk find` command, reuse logic for `qmk mass-compile`. (qmk#20139) * [Keyboard] 1upkeyboards/pi40 update (qmk#20066) * [keyboard] Viktus Minne (qmk#19977) Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Fix typos in readme for Lily58 R2G (qmk#20149) * [Keyboard] Add yandrstudio/transition80 (qmk#19790) Co-authored-by: Drashna Jaelre <[email protected]> * De-parallelise CI (qmk#20171) * De-parallelise CI No speed increase. * Update .github/workflows/ci_builds.yml * [Keymap] crkbd toinux update (qmk#19673) * [Keyboard] Add Coban Pad 3A (qmk#19634) * Add Support for LPAD (qmk#19852) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * Fixup kbdfans/tiger80 RGB animations (qmk#20164) * Format code according to conventions (qmk#20175) * Update lpad info.json (qmk#20184) Update incorrect row and col pins, now confirmed working via manual build in QMK MSYS * [Keyboard] Add Blu vimclutch (qmk#20060) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keymap] for sharkby7e (qmk#20121) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> * [Keyboard] Add Kuro65 keyboard (qmk#20122) Co-authored-by: jack <[email protected]> Co-authored-by: Less/Rikki <[email protected]> * [Keyboard] Add CannonKeys Bakeneko60 ISO Hotswap PCB (qmk#20130) * [Keyboard] Add pteropus keyboard (qmk#20147) Co-authored-by: Less/Rikki <[email protected]> Co-authored-by: Chi-Han Yang <[email protected]> * [Keyboard] OSAv2 (qmk#20166) * [Keyboard] Olly Orion: Disable SWD and JTAG (qmk#20169) Co-authored-by: Joel Challis <[email protected]> * [Keyboard] Add tiny board 16 rgb keyboard (qmk#20158) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] update creek70 change rgb num (qmk#20196) Co-authored-by: Drashna Jaelre <[email protected]> * Adding Bad Wings Support (qmk#20153) * fixup: correct filename (qmk#20212) * [Keyboard] Add via support for jotanck keyboard (qmk#20146) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Add Geistmaschine Geist (qmk#20117) Co-authored-by: jack <[email protected]> * [Keyboard] Ymd09 config updates (qmk#20124) Co-authored-by: jack <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Fix tata80 wkl layout (qmk#20195) * [jacky_studio/piggy60] warn about incompatible PCB rev (qmk#20232) * EC 60 PCB (qmk#20050) * Add EC 60 PCB firmware * Moved from data driven row/col def to config def * Implemented proper LAYOUT_ changes * Removed unnecessary `.h` includes * Added `DISCHARGE_TIME` Addition of a `DISCHARGE_TIME` time. This is to ensure that the ghost capacitor that is the row strobed for the ADC read, is fully drained and doesn't carry charges that deviates the readings. Tested on multiple hardware and confirmed working and improving the readings, both in terms of stability and consistency for baseline noise. * Update readme.md Added missing `cipulot/`in readme example commands * Update keyboards/cipulot/ec_60/readme.md Co-authored-by: Tom Barnes <[email protected]> * Removal of `info.json` lines as suggested * Update to comply with `_kb` and `_user` separation * Update keyboards/cipulot/ec_60/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> --------- Co-authored-by: Tom Barnes <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * EC 23U PCB (qmk#20049) * Add EC 23U PCB firmware * Moved from data driven row/col def to config def * Implemented proper LAYOUT_ changes * Removed unnecessary `.h` includes * Updated default thresholds * Added `DISCHARGE_TIME` Addition of a `DISCHARGE_TIME` time. This is to ensure that the ghost capacitor that is the row strobed for the ADC read, is fully drained and doesn't carry charges that deviates the readings. Tested on multiple hardware and confirmed working and improving the readings, both in terms of stability and consistency for baseline noise. * Update readme.md Added missing `cipulot/` in example commands. * Removal of `info.json` lines as suggested * Update to comply with `_kb` and `_user` separation * Update rules.mk * EC ProX PCB (qmk#20047) * Add EC Pro X Addition of EC Pro X PCB series. This series comprises 2 versions: - ANSI/ISO - JIS The PCBs are different and are compatible only with their respective cases. * Moved from data driven row/col def to config def * Added project url in info.json * Implemented proper `LAYOUT_` changes * Removen unnecessary `.h` includes * Removal of `"w": 1` * Added `DISCHARGE_TIME` Addition of a `DISCHARGE_TIME` time. This is to ensure that the ghost capacitor that is the row strobed for the ADC read, is fully drained and doesn't carry charges that deviates the readings. Tested on multiple hardware and confirmed working and improving the readings, both in terms of stability and consistency for baseline noise. * Fixed keymap error in ordering * Update keyboards/cipulot/ec_prox/jis/readme.md Co-authored-by: Tom Barnes <[email protected]> * Update keyboards/cipulot/ec_prox/ansi_iso/readme.md Co-authored-by: Tom Barnes <[email protected]> * Removal of `info.json` lines as suggested * Update to comply with `_kb` and `_user` separation * Update keyboards/cipulot/ec_prox/jis/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> * Update rules.mk --------- Co-authored-by: Tom Barnes <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [keyboard] Correcting info.JSON for Viktus Minne (qmk#20244) * [Keyboard]Viktus Minne - Topre variant (qmk#20044) * Adding the Viktus Minne topre pcb variant * Update keyboards/viktus/minne_topre/readme.md Co-authored-by: Drashna Jaelre <[email protected]> * Update rules.mk * Moving layouts from *.h to info.json * Removing minne_topre.h and updating others * fixing *.c's * Switch from int to void for ec_init * Update info.json * Update info.json --------- Co-authored-by: Drashna Jaelre <[email protected]> * Add CannonKeys Bakeneko65 Hotswap ISO PCB to QMK (qmk#20131) * Add CannonKeys Bakeneko65 Hotswap ISO PCB to QMK * Add 65_iso_blocker community layout support * Bump actions/stale from 7 to 8 (qmk#20246) Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Documentation] Pointing device minor rewrite (qmk#19641) * Check for multiple matrix positions assigned to same key (qmk#20039) * [chore] keyboards/tzarc: Alignment with clang-format. (qmk#20265) * [keyboard] Correcting info.JSON for OSAv2 (qmk#20247) * Remove invalid characters (qmk#20277) * Add new keyboard Tightwriter (qmk#20136) Co-authored-by: Less/Rikki <[email protected]> * I have zero involvement with this keyboard... (qmk#20287) * CI Builds: master/develop, default/via, twice daily. (qmk#20283) * Fix some invalid layout macros (qmk#20256) * Add step summary output to CI builds, with failure logs. (qmk#20288) * Fixup CI command failures. (qmk#20291) * Add ability for `qmk mass-compile` to build specified targets (qmk#20294) * Minify content published to API (qmk#20285) * [Keyboard] Add alhenkb macropad (qmk#20123) * [Keyboard] Add Plaque80 (qmk#20240) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Joel Challis <[email protected]> * [Keyboard] Add Steezy60 Rev B (qmk#19688) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Nick Brassel <[email protected]> Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Wolf Van Herreweghe <[email protected]> Co-authored-by: yiancar <[email protected]> Co-authored-by: Dasky <[email protected]> Co-authored-by: adophoxia <[email protected]> Co-authored-by: Jue Liu <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: Shandon Anderson <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: jason <[email protected]> Co-authored-by: Less/Rikki <[email protected]> * [Keyboard] Add KeyDeck8 (qmk#20107) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * Revert to hex output for kint41 (qmk#20295) * [Keyboard update] Fix json error (qmk#20299) * [QP] Fix up delta frame boundaries (qmk#20296) * [Keymap] Add md40 ckrbd keymap (qmk#19931) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keymap] Ferris - Add split USB detection directive (qmk#20213) * [Keyboard] Add GMMK Numpad (qmk#20067) Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keymap] update arkag keymap, add hitbox layout (qmk#20271) Co-authored-by: Alex Kagno <[email protected]> * Add angle65 (qmk#19986) Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> * Enable encoder mapping in VIA for Keebio KBO-5000 (qmk#20272) * [Keyboard] Add Mechlovin9 rev.3 (qmk#20119) Co-authored-by: jack <[email protected]> * [Keyboard] Add Royal Kludge RKG-68 (qmk#20138) * [Keyboard] Add pocketpad (qmk#20229) Co-authored-by: jack <[email protected]> * [Keyboard] Add Erdnuss 65 (qmk#20202) Co-authored-by: jack <[email protected]> * [Keymap] Add dancxjo hotdox76v2 keymap (qmk#20016) * Add support for Geistmaschine Macropod (qmk#20116) Co-authored-by: Pablo Martínez <[email protected]> * [Keyboard] Add nullbits SNAP keyboard (qmk#18916) Co-authored-by: Ryan <[email protected]> * Add user horrortroll in userspace (qmk#19769) * Add recommendations for VSCode intellisense (qmk#19402) * ISO-DE Keymap for Dactyl Manuform 6x7 (qmk#19441) * [Bugfix] Check QGF's bpp against display's native_bits_per_pixel (qmk#19995) * Adding my keymap (qmk#19964) * Update WT60-H1, WT60-H3 layouts (qmk#20114) * onekey: Fix console output on AVR (qmk#19930) * New layer added to giabalanai keyboard (qmk#20118) * Adding Unextended Standard PCB (qmk#20190) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: 4pplet <[email protected]> Co-authored-by: 4pplet <[email protected]> * Refactor Galatea (qmk#20011) * Add an alternate layout definition for Keyboardio Model 01 (qmk#20245) * Suggest `qmk list-keyboards` when testing build environment (qmk#19471) Co-authored-by: Joel Challis <[email protected]> * Data-driven updates to overnumpad controller keyboards (qmk#20259) * PR checklist: keyboard updates must go to `develop` (qmk#20323) * Modify default encoder mappings, change PID, enable mousekeys (qmk#20329) * Adding Oceanographer to QMK. (qmk#20324) * Personal keymaps for crkbd and kyria (qmk#20009) * Add Ripple TKL Hotswap Firmware (qmk#20302) Co-authored-by: Less/Rikki <[email protected]> * Add Ripple TKL Keyboard firmware (qmk#20301) * [keyboard] Adding OSAv2 numpad (qmk#20209) Co-authored-by: jack <[email protected]> * Use table for debounce algorithm description (qmk#20322) * Manibus keyboard, update pinout (qmk#20309) * Add debounce time description (qmk#20333) * Resolve keyboard names for `qmk mass-compile`. (qmk#20335) * [Keyboard] Add Budgy and Crowboard Keyboards (qmk#19141) Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * Add Junco Keyboard (qmk#19516) * [Keyboard] Add lxxt (qmk#19935) Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]> * Add Iron160 I160-S and I160-H PCBs support (qmk#20077) Co-authored-by: Ryan <[email protected]> Co-authored-by: jack <[email protected]> * Add peterfalken userspace & keymaps (qmk#19897) Co-authored-by: Peter.Falken <[email protected]> * Bump peter-evans/create-pull-request from 4 to 5 (qmk#20346) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v4...v5) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Keyboard] Add Keychron Q11 (qmk#20125) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: adophoxia <[email protected]> Co-authored-by: Ryan <[email protected]> * Move a_dux to data-driven (qmk#20043) * Add Discord webhook at end of each CI run. (qmk#20355) * Fixup CI build variables. (qmk#20357) * Avoid generating empty ENCODER_RESOLUTION (qmk#20179) * Convertors documentation: Removed duplicate table entry (qmk#20360) * [Keyboard] Add audio support to Adafruit MacroPad RP2040 (qmk#20353) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: QMK Bot <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: TommyZ <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Nick Brassel <[email protected]> Co-authored-by: chickenman112 <[email protected]> Co-authored-by: Sắn <[email protected]> Co-authored-by: Emrik Östling <[email protected]> Co-authored-by: pauper <[email protected]> Co-authored-by: Jason Chestnut <[email protected]> Co-authored-by: ThePanduuh <[email protected]> Co-authored-by: Álvaro A. Volpato <[email protected]> Co-authored-by: Paul James <[email protected]> Co-authored-by: jonylee@hfd <[email protected]> Co-authored-by: CoffeeIsLife <[email protected]> Co-authored-by: Fae <[email protected]> Co-authored-by: Kenny Hung (he) <[email protected]> Co-authored-by: Eugenio Pastoral <[email protected]> Co-authored-by: precondition <[email protected]> Co-authored-by: Wilba <[email protected]> Co-authored-by: azhizhinov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Shawn Meier <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: studiokestra <[email protected]> Co-authored-by: Michal S <[email protected]> Co-authored-by: gkeyboard <[email protected]> Co-authored-by: Paul Enrico N. Viola <[email protected]> Co-authored-by: David Rambo <[email protected]> Co-authored-by: Albert Y <[email protected]> Co-authored-by: Guillermo Aguirre <[email protected]> Co-authored-by: Elliot Powell <[email protected]> Co-authored-by: lalalademaxiya1 <[email protected]> Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Leon Anavi <[email protected]> Co-authored-by: gumorr <[email protected]> Co-authored-by: souvlakeeb <[email protected]> Co-authored-by: Dmitry Nosachev <[email protected]> Co-authored-by: Robert Mills <[email protected]> Co-authored-by: Olivia <[email protected]> Co-authored-by: peepeetee <[email protected]> Co-authored-by: Niles Tanner <[email protected]> Co-authored-by: Freather <[email protected]> Co-authored-by: CMM.Studio Freather <[email protected]> Co-authored-by: Cipulot <[email protected]> Co-authored-by: Anjheos <[email protected]> Co-authored-by: Less/Rikki <[email protected]> Co-authored-by: Anjheos <[email protected]> Co-authored-by: Flame Soulis <[email protected]> Co-authored-by: Budiman Jojo <[email protected]> Co-authored-by: frobiac <[email protected]> Co-authored-by: Mark Stosberg <[email protected]> Co-authored-by: Kuribayashi Atsushi <[email protected]> Co-authored-by: Andrew Kannan <[email protected]> Co-authored-by: Danny <[email protected]> Co-authored-by: paulgali <[email protected]> Co-authored-by: Vino Rodrigues <[email protected]> Co-authored-by: Christopher Hoage <[email protected]> Co-authored-by: ebastler <[email protected]> Co-authored-by: Dan White <[email protected]> Co-authored-by: Andrew Kannan <[email protected]> Co-authored-by: Darkhan <[email protected]> Co-authored-by: Tom Barnes <[email protected]> Co-authored-by: Sophie Machen <[email protected]> Co-authored-by: d-floe <[email protected]> Co-authored-by: adophoxia <[email protected]> Co-authored-by: Kyle McCreery <[email protected]> Co-authored-by: Conor Burns <[email protected]> Co-authored-by: Josh Hinnebusch <[email protected]> Co-authored-by: dztech <[email protected]> Co-authored-by: mjbogusz <[email protected]> Co-authored-by: しぐれ <[email protected]> Co-authored-by: ToffeeStudio <[email protected]> Co-authored-by: ziptyze <[email protected]> Co-authored-by: blindassassin111 <[email protected]> Co-authored-by: Fabien <[email protected]> Co-authored-by: JX <[email protected]> Co-authored-by: toinux <[email protected]> Co-authored-by: Dam Vu Duy <[email protected]> Co-authored-by: Laneware <[email protected]> Co-authored-by: Agent Blu, 006 <[email protected]> Co-authored-by: Sid Quinsaat <[email protected]> Co-authored-by: Tobias Minn <[email protected]> Co-authored-by: hulahermit <[email protected]> Co-authored-by: Chi-Han Yang <[email protected]> Co-authored-by: mechlovin <[email protected]> Co-authored-by: Ning <[email protected]> Co-authored-by: spbgzh <[email protected]> Co-authored-by: Jason Hazel <[email protected]> Co-authored-by: jotix <[email protected]> Co-authored-by: SHVD3x <[email protected]> Co-authored-by: Pablo Martínez <[email protected]> Co-authored-by: takashicompany <[email protected]> Co-authored-by: Alejandro Chacón <[email protected]> Co-authored-by: 4pplet <[email protected]> Co-authored-by: Wolf Van Herreweghe <[email protected]> Co-authored-by: yiancar <[email protected]> Co-authored-by: Dasky <[email protected]> Co-authored-by: Jue Liu <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: Shandon Anderson <[email protected]> Co-authored-by: jason <[email protected]> Co-authored-by: Maverick0197 <[email protected]> Co-authored-by: Shane Dowling <[email protected]> Co-authored-by: Cameron Varley <[email protected]> Co-authored-by: Alexander Kagno <[email protected]> Co-authored-by: Alex Kagno <[email protected]> Co-authored-by: Vertex-kb <[email protected]> Co-authored-by: Raphael Mangubat <[email protected]> Co-authored-by: Thomaz Peres <[email protected]> Co-authored-by: butterkeebs <[email protected]> Co-authored-by: cttt <[email protected]> Co-authored-by: Travis Reed <[email protected]> Co-authored-by: Jay Greco <[email protected]> Co-authored-by: HorrorTroll <[email protected]> Co-authored-by: Woongbin Kang <[email protected]> Co-authored-by: andi4000 <[email protected]> Co-authored-by: Torsten Schneider <[email protected]> Co-authored-by: 3araht <[email protected]> Co-authored-by: 4pplet <[email protected]> Co-authored-by: 4pplet <[email protected]> Co-authored-by: Lisa Ugray <[email protected]> Co-authored-by: Julius Degesys <[email protected]> Co-authored-by: Purdea Andrei <[email protected]> Co-authored-by: Cameron Larsen <[email protected]> Co-authored-by: Alex Paulescu <[email protected]> Co-authored-by: Alex Miller <[email protected]> Co-authored-by: Dane Skalski <[email protected]> Co-authored-by: DeskDaily <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Luis Garcia <[email protected]> Co-authored-by: Peter.Falken <[email protected]> Co-authored-by: Duncan Sutherland <[email protected]>

Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>

RustedAperture added 2 commits March 8, 2023 15:20

GMMK Numpad (Default, Via, Vial)

eb6555f

Fix Product URL

f0b17ab

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 8, 2023

RustedAperture changed the title ~~Adding GMMK Numpad (Default, Via, Vial)~~ Add GMMK Numpad (Default, Via, Vial) Mar 8, 2023

zvecr added invalid pr_checklist_pending Needs changes as per the PR checklist labels Mar 8, 2023

Fix License Headers

56a3098

Remove Vial, add Readme, Remove duplicate defines

1f89a6d

adophoxia suggested changes Mar 9, 2023

View reviewed changes

keyboards/gmmk/numpad/config.h Outdated Show resolved Hide resolved

keyboards/gmmk/numpad/keymaps/via/config.h Outdated Show resolved Hide resolved

keyboards/gmmk/numpad/numpad.h Outdated Show resolved Hide resolved

Port Keymap, Remove Duplicate config.h

afe4ab9

RustedAperture requested a review from adophoxia March 9, 2023 18:41

adophoxia suggested changes Mar 9, 2023

View reviewed changes

keyboards/gmmk/numpad/info.json Outdated Show resolved Hide resolved

keyboards/gmmk/numpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved

keyboards/gmmk/numpad/numpad.h Outdated Show resolved Hide resolved

RustedAperture added 2 commits March 9, 2023 14:05

Duplicate Encoder Config

f7be695

Clean Up Code

9ef126d

RustedAperture requested a review from adophoxia March 9, 2023 19:07

adophoxia approved these changes Mar 9, 2023

View reviewed changes

RustedAperture changed the title ~~Add GMMK Numpad (Default, Via, Vial)~~ Add GMMK Numpad (Default, Via) Mar 9, 2023

waffle87 requested changes Mar 9, 2023

View reviewed changes

Code Cleanup

3bfc15b

RustedAperture requested a review from waffle87 March 9, 2023 19:33

RustedAperture added 3 commits March 9, 2023 14:41

Fix RGB

42c8ad9

encoder_update_user

e7f9f9c

Reverse Encoder

e60e917

waffle87 approved these changes Mar 10, 2023

View reviewed changes

Update keyboards/gmmk/numpad/numpad.c

2f7a64e

Co-authored-by: Drashna Jaelre <[email protected]>

RustedAperture requested review from drashna and removed request for sigprof March 16, 2023 08:32

Update Headers

d62b9d2

SamGowland mentioned this pull request Mar 19, 2023

Adding new macro board called tapedeck #20161

Closed

11 tasks

drashna requested changes Mar 21, 2023

View reviewed changes

RustedAperture and others added 4 commits March 20, 2023 23:32

Update keyboards/gmmk/numpad/info.json

e45d852

Co-authored-by: Drashna Jaelre <[email protected]>

remove uneeded code

8c0d31c

Add Matrix for push encoder (but no encoder push yet)

29b5080

Added Working Encoder Push!!!!!

935d5b6

RustedAperture requested a review from drashna March 21, 2023 06:15

RustedAperture added 2 commits March 21, 2023 02:19

Update layout to show where the encoder is

b5cfdf0

Show encoder position on default keymap

864a05a

drashna requested changes Mar 21, 2023

View reviewed changes

keyboards/gmmk/numpad/config.h Outdated Show resolved Hide resolved

keyboards/gmmk/numpad/matrix.c Outdated Show resolved Hide resolved

keyboards/gmmk/numpad/matrix.c Outdated Show resolved Hide resolved

RustedAperture and others added 3 commits March 21, 2023 11:07

Update keyboards/gmmk/numpad/matrix.c

cd15863

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/gmmk/numpad/matrix.c

a1335c4

Co-authored-by: Drashna Jaelre <[email protected]>

update keyboards/gmmk/numpad/config.h

00ab7b9

RustedAperture requested a review from drashna March 21, 2023 15:12

Add Keyboard Image

fe67ef9

drashna approved these changes Mar 23, 2023

View reviewed changes

drashna requested a review from a team March 23, 2023 05:21

drashna merged commit b53356f into qmk:master Apr 2, 2023

RustedAperture mentioned this pull request Apr 3, 2023

Add GMMK Numpad the-via/keyboards#1803

Merged

7 tasks

coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Apr 6, 2023

[Keyboard] Add GMMK Numpad (qmk#20067)

505032e

Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>

struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request Apr 10, 2023

[Keyboard] Add GMMK Numpad (qmk#20067)

a562255

Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>

rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request Apr 18, 2023

[Keyboard] Add GMMK Numpad (qmk#20067)

1a8bddb

Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GMMK Numpad (Default, Via) #20067

Add GMMK Numpad (Default, Via) #20067

RustedAperture commented Mar 8, 2023 •

edited

Loading

tzarc commented Mar 8, 2023

RustedAperture commented Mar 9, 2023

RustedAperture commented Mar 9, 2023

adophoxia left a comment

RustedAperture commented Mar 9, 2023

RustedAperture commented Mar 20, 2023

Add GMMK Numpad (Default, Via) #20067

Add GMMK Numpad (Default, Via) #20067

Conversation

RustedAperture commented Mar 8, 2023 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

tzarc commented Mar 8, 2023

RustedAperture commented Mar 9, 2023

RustedAperture commented Mar 9, 2023

adophoxia left a comment

Choose a reason for hiding this comment

RustedAperture commented Mar 9, 2023

RustedAperture commented Mar 20, 2023

RustedAperture commented Mar 8, 2023 •

edited

Loading