Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GMMK Numpad #1803

Merged
merged 2 commits into from
Apr 8, 2023
Merged

Add GMMK Numpad #1803

merged 2 commits into from
Apr 8, 2023

Conversation

RustedAperture
Copy link
Contributor

@RustedAperture RustedAperture commented Apr 3, 2023 •
edited
Loading

Description

Adding support for the GMMK Numpad

QMK Pull Request

qmk/qmk_firmware#20067

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert from V2 definition to V3 definition and do not include the V2 definition. https://www.caniusevia.com/docs/v3_changes

@RustedAperture
Copy link
Contributor Author

Please convert from V2 definition to V3 definition and do not include the V2 definition. https://www.caniusevia.com/docs/v3_changes

Looks like I just saved it in the wrong location, will update soon

@RustedAperture RustedAperture requested a review from Xelus22 April 8, 2023 05:35
@RustedAperture
Copy link
Contributor Author

Yep, that seems to have been the issue, moved the Numpad to the V3 folder and now npm run build runs and compiles with no issue.

@Xelus22 Xelus22 merged commit fe8f197 into the-via:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Awaiting requested review from Xelus22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RustedAperture @Xelus22