Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new macro board called tapedeck #20161

Closed
wants to merge 48 commits into from
Closed

Adding new macro board called tapedeck #20161

wants to merge 48 commits into from

Conversation

SamGowland
Copy link
Contributor

@SamGowland SamGowland commented Mar 17, 2023 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Mar 17, 2023
View reviewed changes
keyboards/tapedeck/config.h Outdated Show resolved Hide resolved
keyboards/tapedeck/config.h Outdated Show resolved Hide resolved
keyboards/tapedeck/tapedeck.h Outdated Show resolved Hide resolved
keyboards/tapedeck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tapedeck/tapedeck.c Outdated Show resolved Hide resolved
keyboards/tapedeck/rules.mk Outdated Show resolved Hide resolved
keyboards/tapedeck/rules.mk Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Show resolved Hide resolved
@SamGowland SamGowland requested a review from waffle87 March 17, 2023 16:55
lesshonor
lesshonor suggested changes Mar 17, 2023
View reviewed changes
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/readme.md Outdated Show resolved Hide resolved
keyboards/tapedeck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tapedeck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tapedeck/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/tapedeck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
SamGowland and others added 12 commits March 17, 2023 22:50
@SamGowland @lesshonor
Update keyboards/tapedeck/info.json
61c415e 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/info.json
62b4f47 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/info.json
907b3d8 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/info.json
9c3a9c3 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/keymaps/default/keymap.c
083f2db 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/keymaps/default/keymap.c
13f312f 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/keymaps/default/keymap.c
f991ff6 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/info.json
83d888e 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/readme.md
8ff164b 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/info.json
de298db 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/readme.md
8cac909 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland @lesshonor
Update keyboards/tapedeck/rules.mk
49bee45 
Co-authored-by: Less/Rikki <[email protected]>
@SamGowland SamGowland requested a review from fauxpark March 21, 2023 15:51
drashna
drashna requested changes Mar 21, 2023
View reviewed changes
keyboards/tapedeck/tapedeck.c Outdated Show resolved Hide resolved
keyboards/tapedeck/tapedeck.c Outdated Show resolved Hide resolved
keyboards/tapedeck/tapedeck.c Outdated Show resolved Hide resolved
keyboards/tapedeck/tapedeck.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 23, 2023 05:26
zvecr
zvecr requested changes Mar 23, 2023
View reviewed changes
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tapedeck/rules.mk Outdated Show resolved Hide resolved
@SamGowland SamGowland requested review from zvecr and removed request for fauxpark March 24, 2023 11:36
zvecr
zvecr requested changes Mar 24, 2023
View reviewed changes
keyboards/tapedeck/config.h Outdated Show resolved Hide resolved
keyboards/tapedeck/info.json Outdated Show resolved Hide resolved
keyboards/tapedeck/config.h
Comment on lines +18 to +20
/* SLIDER */
#define POT_ENABLE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the implementation doesnt really allow that?

keyboards/tapedeck/tapedeck.c Outdated Show resolved Hide resolved
@SamGowland SamGowland requested review from zvecr and waffle87 and removed request for zvecr March 26, 2023 15:59
sigprof
sigprof requested changes Apr 11, 2023
View reviewed changes
keyboards/tapedeck/keymaps/rules.mk Outdated Show resolved Hide resolved
@drashna drashna self-requested a review April 11, 2023 19:21
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark requested changes

@sigprof sigprof sigprof requested changes

@lesshonor lesshonor lesshonor approved these changes

@waffle87 waffle87 Awaiting requested review from waffle87

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SamGowland @sigprof @drashna @fauxpark @zvecr @waffle87 @lesshonor