Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sinc Rev. 1-2 Encoder Map #18861

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add Sinc Rev. 1-2 Encoder Map #18861

merged 1 commit into from
Oct 28, 2022

Conversation

nooges
Copy link
Member

@nooges nooges commented Oct 26, 2022

Description

Migrate Sinc Rev. 1 and 2 to a different PID to allow for updated VIA .json to be used for encoder mapping support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna merged commit e31fa77 into qmk:master Oct 28, 2022
@nooges nooges deleted the sinc-encoder-map branch October 28, 2022 20:25
hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
wezzynl added a commit to wezzynl/qmk_firmware that referenced this pull request Nov 8, 2022
* master: (5478 commits)
  [Keyboard] Add Brutal v2 1800 PCB to QMK (qmk#18891)
  [Keyboard] Refactor chinese PCB folder (qmk#18923)
  [Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
  [Keymap] Add model01 and doio/kb16 keymaps (qmk#18681)
  [Keymap] KO Kyria (qmk#18413)
  [Keyboard] Add Work Louder Numpad (qmk#18912)
  [Keyboard]  Add hotdox76v2 support (qmk#18680)
  Refactor to avoid deprecated wmic execution (qmk#18122)
  Phoebe: Add key to print screen (qmk#18856)
  Star75 Refactor (qmk#18885)
  [Keyboard] Add Hubble keyboard (qmk#18718)
  Remove duplicate key in novelkeys/nk65b (qmk#18907)
  [Keyboard] Update Kay65 LED state (qmk#18895)
  Add indicator LEDs to hoodrow G PCB (qmk#18888)
  [Keymap] toshi0383 keymaps update (qmk#18760)
  [Keyboard] Add Encoder map support for rart (qmk#18851)
  [Keyboard] Add Sinc Rev 1&2 Encoder Map Support (qmk#18861)
  Docs: fix a typo (qmk#18896)
  MelGeek MJ6XY Refactor (qmk#18862)
  [Keyboard] Minor Aurora Sweep fixes (qmk#18879)
  ...
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants