Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Encoder map support for rart #18851

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Add Encoder map support for rart #18851

merged 2 commits into from
Oct 28, 2022

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented Oct 26, 2022 •
edited
Loading

Description

  • Add encoder mapping for rart4x4, rart75, rart75hs, rart75m and rartpad
  • Add encoder map enable to utilize encoder mapping
  • Fix pin capslock and RGB fot rart80

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 26, 2022
drashna
drashna requested changes Oct 26, 2022
View reviewed changes
keyboards/rart/rart75hs/rart75hs.c Outdated Show resolved Hide resolved
keyboards/rart/rart75m/rart75m.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team October 27, 2022 16:29
@alabahuy alabahuy mentioned this pull request Oct 28, 2022
Merged
6 tasks
@drashna drashna merged commit bc50234 into qmk:master Oct 28, 2022
@alabahuy alabahuy deleted the Encoder branch October 28, 2022 23:27
hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
@rezaadio @hirakiuc
[Keyboard] Add Encoder map support for rart (qmk#18851)
1344f80
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@rezaadio
[Keyboard] Add Encoder map support for rart (qmk#18851)
1db6f2f
wezzynl added a commit to wezzynl/qmk_firmware that referenced this pull request Nov 8, 2022
@wezzynl
Merge branch 'master' into dev
6358305 
* master: (5478 commits)
  [Keyboard] Add Brutal v2 1800 PCB to QMK (qmk#18891)
  [Keyboard] Refactor chinese PCB folder (qmk#18923)
  [Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
  [Keymap] Add model01 and doio/kb16 keymaps (qmk#18681)
  [Keymap] KO Kyria (qmk#18413)
  [Keyboard] Add Work Louder Numpad (qmk#18912)
  [Keyboard]  Add hotdox76v2 support (qmk#18680)
  Refactor to avoid deprecated wmic execution (qmk#18122)
  Phoebe: Add key to print screen (qmk#18856)
  Star75 Refactor (qmk#18885)
  [Keyboard] Add Hubble keyboard (qmk#18718)
  Remove duplicate key in novelkeys/nk65b (qmk#18907)
  [Keyboard] Update Kay65 LED state (qmk#18895)
  Add indicator LEDs to hoodrow G PCB (qmk#18888)
  [Keymap] toshi0383 keymaps update (qmk#18760)
  [Keyboard] Add Encoder map support for rart (qmk#18851)
  [Keyboard] Add Sinc Rev 1&2 Encoder Map Support (qmk#18861)
  Docs: fix a typo (qmk#18896)
  MelGeek MJ6XY Refactor (qmk#18862)
  [Keyboard] Minor Aurora Sweep fixes (qmk#18879)
  ...
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@rezaadio @thystips
[Keyboard] Add Encoder map support for rart (qmk#18851)
529341f
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@rezaadio @ramonimbao
[Keyboard] Add Encoder map support for rart (qmk#18851)
17bc2ae
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@rezaadio @nolanseaton
[Keyboard] Add Encoder map support for rart (qmk#18851)
e79d1dc
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@rezaadio @ChrisChrisLoLo
[Keyboard] Add Encoder map support for rart (qmk#18851)
e4bf768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alabahuy @drashna @fauxpark @rezaadio