Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISO Encoder variant of Keychron Q1v1 #18829

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Add ISO Encoder variant of Keychron Q1v1 #18829

merged 6 commits into from
Nov 8, 2022

Conversation

adophoxia
Copy link
Contributor

Description

  • Adds the ISO Encoder variant of the Keychron Q1v1 (A means to complete the v1 revision of the Q1)
    • Made to be in spec with how the Q3 was structured to make use of the new common folder for the KC-specific custom keycodes and other functionality.
    • Added new compile option in q1.h. (Should not be able to conflict with #18713 if/when it gets merged.)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 24, 2022
@drashna drashna requested a review from a team October 25, 2022 05:34
@adophoxia adophoxia requested a review from fauxpark October 25, 2022 15:19
@drashna drashna merged commit a25e5ce into qmk:master Nov 8, 2022
@adophoxia adophoxia deleted the keychron-q1v1-iso-encoder branch November 8, 2022 16:25
@tzarc tzarc mentioned this pull request Nov 9, 2022
Merged
14 tasks
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@adophoxia @thystips
[Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
3f6954d
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@adophoxia @ramonimbao
[Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
a786c70
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@adophoxia @elpekenin
[Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
32905e2
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@adophoxia @nolanseaton
[Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
a3b9c1f
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@adophoxia @ChrisChrisLoLo
[Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
7520dac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adophoxia @drashna @fauxpark