Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add yandrstudio/nz67v2 keyboard. #17591

Merged
merged 22 commits into from
Aug 20, 2022

Conversation

jiaxin96
Copy link
Contributor

@jiaxin96 jiaxin96 commented Jul 7, 2022

Description

add nz67v2 keyboard.
RESET => QK_BOOT in readme of nz64 and zhou65.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 7, 2022
keyboards/yandrstudio/nz67v2/config.h Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/config.h Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/config.h Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/nz67v2.c Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/readme.md Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/config.h Outdated Show resolved Hide resolved
@jiaxin96 jiaxin96 requested a review from drashna July 11, 2022 13:51
@drashna drashna requested a review from a team July 11, 2022 20:34
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason you have not included an info.json?

@jiaxin96
Copy link
Contributor Author

1

The info.json file has been supplemented according to the qmk format requirements. Please review it again.

keyboards/yandrstudio/nz67v2/info.json Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/config.h Outdated Show resolved Hide resolved
keyboards/yandrstudio/nz67v2/rules.mk Outdated Show resolved Hide resolved
jiaxin96 and others added 2 commits August 16, 2022 12:04
Delete the duplicate definition of info.json

Co-authored-by: Ryan <[email protected]>
Delete the duplicate definition of info.json

Co-authored-by: Ryan <[email protected]>
keyboards/yandrstudio/nz67v2/info.json Outdated Show resolved Hide resolved
@jiaxin96 jiaxin96 requested a review from fauxpark August 16, 2022 04:11
@keyboard-magpie keyboard-magpie merged commit 706995c into qmk:master Aug 20, 2022
SjB added a commit to SjB/qmk_firmware that referenced this pull request Sep 16, 2022
* upstream/master: (41 commits)
  Add missing DD mapping for RGB_MATRIX_DRIVER (qmk#18160)
  Refactor pianoforte for configurator (qmk#18159)
  Fix use of encoder map in mechlovin/zed65/retro66 (qmk#18158)
  Fix use of encoder map in mechlovin/foundation (qmk#18157)
  Update invalid pip install flag (qmk#18146)
  Fix use of encoder map in mechwild/clunker (qmk#18156)
  [Keyboard] Add Plywrks Lune (qmk#17057)
  [Keyboard] Add Clunker (qmk#18141)
  Use correct board files for cantor (qmk#18144)
  [Keyboard] Enable VIA - ALF X1.1 (qmk#18140)
  [Keyboard] add rgb animation handwired/swiftrax/glacier (qmk#18121)
  Update Tap Dance Example 4 (qmk#18138)
  Remove USB IDs and strings from `fungo/rev1` (qmk#18133)
  Move keyboard USB IDs and strings to data driven, pass 3 (qmk#18111)
  Add pcewing Speedo v3 keymap (qmk#18118)
  [Keymap] Add new keymap to nasu (qmk#18024)
  [Keyboard] Add ai macropad (qmk#17722)
  added keymap for kprepublic/jj40:brdlf (qmk#17961)
  [Keyboard] Add yandrstudio/nz67v2 keyboard. (qmk#17591)
  Format code according to conventions (qmk#18119)
  ...
@jiaxin96 jiaxin96 deleted the nz67 branch November 19, 2022 17:51
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants