Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Add new keymap to nasu #18024

Merged
merged 3 commits into from
Aug 21, 2022
Merged

[Keymap] Add new keymap to nasu #18024

merged 3 commits into from
Aug 21, 2022

Conversation

MarioCadenas
Copy link

@MarioCadenas MarioCadenas commented Aug 13, 2022

Description

Added a new keymap with a functionality to switch on the numlock indicator when activating the layer 1.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@MarioCadenas MarioCadenas requested a review from drashna August 14, 2022 10:01
@MarioCadenas MarioCadenas force-pushed the extend-nasu branch 3 times, most recently from e8f1a34 to 6918717 Compare August 14, 2022 11:29
@MarioCadenas
Copy link
Author

Hi @drashna , is there any other actions to do to get this approved and merged? Thank you 😄

@drashna drashna merged commit 93f0c1f into qmk:master Aug 21, 2022
@MarioCadenas MarioCadenas deleted the extend-nasu branch August 30, 2022 10:33
SjB added a commit to SjB/qmk_firmware that referenced this pull request Sep 16, 2022
* upstream/master: (41 commits)
  Add missing DD mapping for RGB_MATRIX_DRIVER (qmk#18160)
  Refactor pianoforte for configurator (qmk#18159)
  Fix use of encoder map in mechlovin/zed65/retro66 (qmk#18158)
  Fix use of encoder map in mechlovin/foundation (qmk#18157)
  Update invalid pip install flag (qmk#18146)
  Fix use of encoder map in mechwild/clunker (qmk#18156)
  [Keyboard] Add Plywrks Lune (qmk#17057)
  [Keyboard] Add Clunker (qmk#18141)
  Use correct board files for cantor (qmk#18144)
  [Keyboard] Enable VIA - ALF X1.1 (qmk#18140)
  [Keyboard] add rgb animation handwired/swiftrax/glacier (qmk#18121)
  Update Tap Dance Example 4 (qmk#18138)
  Remove USB IDs and strings from `fungo/rev1` (qmk#18133)
  Move keyboard USB IDs and strings to data driven, pass 3 (qmk#18111)
  Add pcewing Speedo v3 keymap (qmk#18118)
  [Keymap] Add new keymap to nasu (qmk#18024)
  [Keyboard] Add ai macropad (qmk#17722)
  added keymap for kprepublic/jj40:brdlf (qmk#17961)
  [Keyboard] Add yandrstudio/nz67v2 keyboard. (qmk#17591)
  Format code according to conventions (qmk#18119)
  ...
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants